[version] part 1: update command for devbox and launcher updates #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
1 task
savil
changed the title
savil
force-pushed
the
savil/version-update
branch
2 times, most recently
from
6496558 to
2ac75ab
Compare
mikeland73
requested changes
May 1, 2023
savil
force-pushed
the
savil/version-update
branch
3 times, most recently
from
3b96873 to
4e6147a
Compare
|
Updated code, but need to test properly. |
savil
force-pushed
the
savil/version-update
branch
7 times, most recently
from
bb7a730 to
be109ec
Compare
savil
changed the title
savil
force-pushed
the
savil/version-update
branch
2 times, most recently
from
3c86906 to
2d0590d
Compare
mikeland73
approved these changes
May 2, 2023
| if err != nil { | ||
| return nil, errors.WithStack(err) | ||
| } | ||
| cmd := exec.Command(exe, "version", "-v") |
There was a problem hiding this comment.
Possibly future hardening is adding --json
There was a problem hiding this comment.
that would be a good idea
savil
force-pushed
the
savil/version-update
branch
from
2d0590d to
af4992b
Compare
|
I'm going to merge #966 into this PR, prior to merging to |
savil
force-pushed
the
savil/version-update
branch
from
af4992b to
892040c
Compare
…on is outdated (#966) ## Summary This PR updates the `vercheck.CheckVersion` to check launcher and devbox CLI binary versions, and print a notice if either is out-of-date. I print the message in all yellow similar to flyctl. But open to other renderings. ## How was it tested? `go test -run TestCheckVersion ./internal/vercheck/...` <img width="596" alt="Screenshot 2023-04-27 at 5 55 04 PM" src="https://user-images.githubusercontent.com/676452/235029194-d7d43c2a-0905-49e4-b90e-2be99a5a1a51.png"> - [ ] TODO: I need to do more manual testing.
savil
added a commit
that referenced
this pull request
May 2, 2023
**Motivation:**
We want to disable auto-update for devbox CLIs. This will minimize
unexpected interruptions for our users.
To do so, we are going to do the following:
1. Update `launch.sh` file in `axiom` repo to write new versions to
`{XDG_CACHE_HOME}/devbox/available-version`.
jetify-com/axiom#3150
2. Change `devbox version update` to update the launcher (if needed) and
else, update the CLI binary. (this PR).
3. Change the `vercheck.CheckVersion` that runs in `boxcli/root.go` on
every command to check if the launcher or CLI binary versions are
out-of-date, and to print a notice if so. (reviewed in #966, but merged
into this PR)
We will cherry-pick ~these two PRs~ this PR for the next release so
auto-update stops for users.
**Implementation:**
This PR enables `jetpack version update` to:
1. Update the launcher: We detect if the launcher version is outdated,
and update it, if needed. This also updates the devbox CLI binary as a
side-effect. This requires `sudo` so we only do it, if necessary.
2. Update just the devbox CLI binary: If the launcher is up-to-date,
then we update just the devbox CLI binary.
3. Remove dependency on new code like `env` package to minimize
cherry-picking merge conflicts.
TODO:
- [x] confirm that we can switch the `devbox version` operation after an
update to `StdOut`. I feel this is better so user is informed about the
new version.
cc @mikeland86 for the above question.
Will only land this after the launch.sh file is updated in
jetify-com/axiom#3150
Did some basic testing:
hardcoded `true` to ensure `selfUpdateLauncher` runs, and did `devbox
version update`:
<img width="742" alt="Screenshot 2023-05-01 at 8 57 46 PM"
src="https://user-images.githubusercontent.com/676452/235576315-03069599-a469-4f3a-90c2-cc6a58ec648a.png">
regular `devbox version update`
<img width="332" alt="Screenshot 2023-05-01 at 8 48 20 PM"
src="https://user-images.githubusercontent.com/676452/235575369-f2a70299-4a3a-4b41-80ec-ecedb730ad0b.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation:
We want to disable auto-update for devbox CLIs. This will minimize unexpected interruptions for our users.
To do so, we are going to do the following:
launch.shfile inaxiomrepo to write new versions to{XDG_CACHE_HOME}/devbox/available-version. https://github.com/jetpack-io/axiom/pull/3150devbox version updateto update the launcher (if needed) and else, update the CLI binary. (this PR).vercheck.CheckVersionthat runs inboxcli/root.goon every command to check if the launcher or CLI binary versions are out-of-date, and to print a notice if so. (reviewed in [version] part 2: print notice if devbox CLI binary or launcher version is outdated #966, but merged into this PR)We will cherry-pick
these two PRsthis PR for the next release so auto-update stops for users.Implementation:
This PR enables
jetpack version updateto:Update the launcher: We detect if the launcher version is outdated, and update it, if needed. This also updates the devbox CLI binary as a side-effect. This requires
sudoso we only do it, if necessary.Update just the devbox CLI binary: If the launcher is up-to-date, then we update just the devbox CLI binary.
Remove dependency on new code like
envpackage to minimize cherry-picking merge conflicts.TODO:
devbox versionoperation after an update toStdOut. I feel this is better so user is informed about the new version.cc @mikeland86 for the above question.
Will only land this after the launch.sh file is updated in https://github.com/jetpack-io/axiom/pull/3150
How was it tested?
Did some basic testing:
hardcoded
trueto ensureselfUpdateLauncherruns, and diddevbox version update:regular
devbox version update