Skip to content

Conversation

hezhizhen
Copy link
Contributor

Summary

  1. add cmdutil package
  2. move command related functions to this package
  3. tweak some error handling

How was it tested?

@hezhizhen hezhizhen marked this pull request as ready for review April 29, 2023 08:45
@hezhizhen hezhizhen force-pushed the cmdutil branch 2 times, most recently from d98e43b to 7a78528 Compare April 29, 2023 14:04
@savil savil requested review from ipince and LucilleH May 1, 2023 16:00
Copy link
Collaborator

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this looks much better!

@hezhizhen
Copy link
Contributor Author

@ipince PTAL

@hezhizhen
Copy link
Contributor Author

@savil PTAL

Copy link
Contributor

@ipince ipince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ipince ipince merged commit b1cd112 into jetify-com:main May 3, 2023
@hezhizhen hezhizhen deleted the cmdutil branch August 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants