Add dummy planners for a bunch of languages #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maor Langz
LucilleH
approved these changes
Sep 9, 2022
planner/empty/empty_planner.go
Outdated
| // Implements interface Planner (compile-time check) | ||
| var _ plansdk.Planner = (*Planner)(nil) | ||
|
|
||
| func (g *Planner) Name() string { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add dummy planners for a bunch of languages; for now they are placeholders that don't do anything, but it sets up the whole structure so we can easily start editing them (or the community can contribute by finding the right file).
In the process refactored the common types and utility functions used by all planners into a
plansdk.Would appreciate a quick review since I'm fearful of constantly running into merge conflicts otherwise (I'm moving the location of the planners everyone is working on)
How was it tested?
go test -v ./...