Skip to content

[envsec] Ensure id token is refreshed #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2023
Merged

[envsec] Ensure id token is refreshed #166

merged 3 commits into from
Oct 2, 2023

Conversation

mikeland73
Copy link
Contributor

Summary

  • Ensure refresh updates id token, previously it was only updating access token.
  • Changed GetSession and a few internal functions to return errors instead of just swallowing it up.

How was it tested?

envsec auth logout
envsec auth whoami
envsec auth login
envsec auth whoami
envsec auth refresh
# inspected id token to ensure it was refreshed

@mikeland73 mikeland73 requested review from loreto and LucilleH October 2, 2023 21:36
loreto
loreto approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeland73 mikeland73 merged commit ce82b9c into main Oct 2, 2023
@mikeland73 mikeland73 deleted the landau/fix-refresh branch October 2, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loreto loreto loreto approved these changes

@LucilleH LucilleH Awaiting requested review from LucilleH

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @loreto