Skip to content

Conversation

ym
Copy link
Contributor

@ym ym commented Mar 3, 2025

No description provided.

@ym ym requested a review from adamshiervani March 3, 2025 21:46
@SuperQ
Copy link
Contributor

SuperQ commented Mar 4, 2025

Hmm, it seems like the real issue is there are too many things in init() functions. Maybe better is to refactor these so that they're loaded by main().

Doing this will be fragile, as if any new init() functions are added, we have to rely on copy-pasta.

@adamshiervani adamshiervani merged commit 554121a into jetkvm:dev Mar 4, 2025
2 of 3 checks passed
@ym
Copy link
Contributor Author

ym commented Mar 4, 2025

Hmm, it seems like the real issue is there are too many things in init() functions. Maybe better is to refactor these so that they're loaded by main().

Doing this will be fragile, as if any new init() functions are added, we have to rely on copy-pasta.

Yes, I'm going to remove the init() functions as they seem to cause more problems than the convenience they bring.

@SuperQ
Copy link
Contributor

SuperQ commented Mar 4, 2025

Yea, I was looking at the overall package structure and thinking it was time for a major cleanup and re-packaging. There's just a lot of side-effect function calling going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants