Skip to content

Conversation

ym
Copy link
Contributor

@ym ym commented Mar 10, 2025

No description provided.

@ym ym requested review from chemhack and adamshiervani March 10, 2025 12:43
Copy link
Contributor

@adamshiervani adamshiervani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the different OSes handles acceleration, there is a high chance that the client mouse will move out of the videoElm before the remote host will. I would suggest attaching the mouse handler area outside the video element (the dotted area without the action bar).

Maybe even both handlers can use the that outer container as the handler, as the mouse move function, is clamping the position in absolute mode to the video area.

My suggestion is not a final solution, but good enough until we get the Pointer Lock implemented

@ym
Copy link
Contributor Author

ym commented Mar 10, 2025

Because of the different OSes handles acceleration, there is a high chance that the client mouse will move out of the videoElm before the remote host will. I would suggest attaching the mouse handler area outside the video element (the dotted area without the action bar).

Maybe even both handlers can use the that outer container as the handler, as the mouse move function, is clamping the position in absolute mode to the video area.

My suggestion is not a final solution, but good enough until we get the Pointer Lock implemented

Yes, I've tried that, but unfortunately Chrome only allows `pointer-lock' for sites behind TLS, and right now we only support plain HTTP for local deployment. I can probably add the feature and a simple note telling users that this feature may not work properly if TLS isn't enabled.

@adamshiervani
Copy link
Contributor

Understood. What I'm trying to say is that before we get TLS up and running, we could simply expand the mouse handler bounding box, so that if there is a mismatch between the client and host mouse, it won't be too disruptive for the user.

Also, we should probably add a label saying this is Experimental to reduce the expectation a bit.

@ym ym force-pushed the feat/relative-mouse branch from 4997153 to fc93b2b Compare March 18, 2025 13:51
@adamshiervani adamshiervani merged commit d52e7d0 into jetkvm:dev Mar 19, 2025
2 of 3 checks passed
@r2lutz7
Copy link

r2lutz7 commented Mar 28, 2025

Question: I have updated to v.0.3.8 and the relative mouse feature is currently still shown as "coming soon."
Do I need to be on the Dev Release channel to be able to enable this option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants