feat: allow user to disable keyboard LED synchronization #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to allow users to disable keyboard LED synchronization. It introduces new state and methods to manage LED sync availability, updates various UI components to reflect and control LED sync preferences, and integrates these changes into key application areas such as device routes, settings, and status displays.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/routes/devices.$id.tsx | Integrates LED sync availability setting on keyboard state retrieval |
| ui/src/routes/devices.$id.settings.keyboard.tsx | Adds a new settings item for controlling LED state synchronization |
| ui/src/hooks/stores.ts | Introduces new state and actions for LED sync and LED state management |
| ui/src/components/WebRTCVideo.tsx | Incorporates LED sync state in RTC-related event handling |
| ui/src/components/VirtualKeyboard.tsx | Adjusts virtual keyboard behavior based on LED sync status |
| ui/src/components/InfoBar.tsx | Displays the LED sync status to users |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
* feat: allow user to disable keyboard LED synchronization * Update ui/src/hooks/stores.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.