feat(websecure): add support for ed25519 certificates #513
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ED25519 certificates to the websecure package. Key changes include adding ED25519 support in the key conversion function within utils.go and introducing tests in ed25519_test.go to validate saving such certificates.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/websecure/utils.go | Added ED25519 key handling in keyToFile via a new switch-case. |
| internal/websecure/ed25519_test.go | Introduced tests for validating ED25519 certificate storage. |
Comments suppressed due to low confidence (1)
internal/websecure/ed25519_test.go:52
- Enhance the test by asserting that the certificate has been properly saved and added to the store, rather than only failing on an error return.
err, _ := certStore.ValidateAndSaveCertificate("ed25519-test.jetkvm.com", fixtureEd25519Certificate, fixtureEd25519PrivateKey, true)
| keyBlock = pem.Block{ | ||
| Type: "ED25519 PRIVATE KEY", | ||
| Bytes: k, |
There was a problem hiding this comment.
Consider marshaling the ED25519 key using a standard encoding function such as x509.MarshalPKCS8PrivateKey for consistency with other key types and to ensure proper PEM formatting.
| keyBlock = pem.Block{ | |
| Type: "ED25519 PRIVATE KEY", | |
| Bytes: k, | |
| b, e := x509.MarshalPKCS8PrivateKey(k) | |
| if e != nil { | |
| return fmt.Errorf("failed to marshal ED25519 private key: %v", e) | |
| } | |
| keyBlock = pem.Block{ | |
| Type: "PRIVATE KEY", | |
| Bytes: b, |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@copilot you bungled the `Type: "PRIVATE KEY", losing the information that it is a ED25519 key.
No description provided.