Skip to content

chore: remove msgpack from gin dependency #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

chore: remove msgpack from gin dependency #833

merged 1 commit into from
Sep 26, 2025
+1 −1

Conversation

ym
Copy link
Contributor

@ym ym commented Sep 25, 2025 •
edited
Loading

It should be able to reduce the binary size by ~7 MB.

https://github.com/jetkvm/kvm/actions/runs/18001570015
https://github.com/ym/jetkvm-kvm/actions/runs/18023015779

➜  Downloads du -sh jetkvm-app\ \(13\)/bin/jetkvm_app
 37M	jetkvm-app (13)/bin/jetkvm_app
➜  Downloads du -sh jetkvm-app\ \(14\)/bin/jetkvm_app
 30M	jetkvm-app (14)/bin/jetkvm_app

IDisposable
IDisposable approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@IDisposable IDisposable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and here I was thinking we should switch away from JSON messaging ;)

@ym ym merged commit 3597789 into jetkvm:dev Sep 26, 2025
4 checks passed
@ym ym deleted the chore/gin-deps branch September 26, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDisposable IDisposable IDisposable approved these changes

@adamshiervani adamshiervani Awaiting requested review from adamshiervani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ym @IDisposable