Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use goimports for lint checking #213

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Conversation

munnerz
Copy link
Contributor

@munnerz munnerz commented Jan 17, 2018

This switches us to use goimports for linting of files. It performs the same role as gofmt, plus also checks import paths and makes sure they are grouped according to guidelines.

For reference, the 'correct' format:

import (
    // stdlib packages
    "fmt"
    "os/exec"

    // external packages
    "github.com/golang/glog"
    "k8s.io/apimachinery/pkg/apis/meta/v1"

    // packages belonging to our repo
    "github.com/jetstack/navigator/pkg/apis/v1alpha1"
)

Release note:

NONE

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-ci-bot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@jetstack-ci-bot
Copy link
Contributor

Automatic merge from submit-queue.

@jetstack-ci-bot jetstack-ci-bot merged commit 20f9f92 into jetstack:master Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants