-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5603 - Single page documentation #5636
Conversation
If we are going to wack out the docbook backend entirely we should clear out the xslt files, basically the src/main/docbkx-* directories. Might be good to go through and make sure none of that is referenced but I think that stuff was mostly just syntax highlighter and font type stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See prior comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the documentation generation, and I get a ton of warnings and errors.
In particular, all source code blocks for XML are broken, so the generated documentation is unreadable.
Remove subs={sub-order}
from everywhere, it's now broken, it's unnecessary in most cases, and should be explicitly added only in blocks that require it.
The "parts" use level 0 sections, should be using level 1 (see warning during generation).
There is also a number of invalid cross references that should be fixed.
jetty-documentation/src/main/asciidoc/administration/alpn/alpn.adoc
Outdated
Show resolved
Hide resolved
As long as this visually looks fine I am good to go with it, it lets us get the updated website leveraging it so we can deploy that going into the 10 and 11 releases. Any content changes we need to make can be done separately. |
@sbordet Any other changes you'd like to see? |
jetty-documentation/src/main/asciidoc/administration/http2/configuring-haproxy.adoc
Outdated
Show resolved
Hide resolved
jetty-documentation/src/main/asciidoc/configuring/security/configuring-form-size.adoc
Outdated
Show resolved
Hide resolved
jetty-documentation/src/main/asciidoc/configuring/security/configuring-form-size.adoc
Outdated
Show resolved
Hide resolved
jetty-documentation/src/main/asciidoc/configuring/security/configuring-form-size.adoc
Outdated
Show resolved
Hide resolved
jetty-documentation/src/main/asciidoc/quick-start/getting-started/jetty-running.adoc
Outdated
Show resolved
Hide resolved
@sbordet Done, not sure how I managed to miss those. CI Building now. Good to go when green? |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…roject into 9.4.x-5603-SinglePageDoc
Issue #5603 Creates single page output for 9.4.x documentation and aligns with 10 and 11 documentation formatting.