fix: "wordGlues" works wrongly under some circumstances #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a diffed circumstance like the following,
old: ... a-<del>B</del>-<del>C</del> ...
new: ... a-<ins>b</ins>- ...
we want to glue them into
old: ... a-<del>B-C</del> ...
new: ... a-<ins>b-</ins> ...
But instead, because of this bug, we have incorrect
old: ... a-<del>B-C</del> ...
new: ... a-<ins>b</ins>- ...
We can fix this by adding some dummy closures before glueing like
old: ... a-<del>B</del>-<del>C</del> ...
new: ... a-<ins>b</ins>-<ins></ins> ...
^^^^^^^^^^^ dummy closure
so that now "old" and "new" have the same amounts of closures.
#25
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
If we have a diffed circumstance like the following,
we want to glue them into
But instead, because of this bug, we have incorrect
Fix
We can fix this by adding some dummy closures before glueing like
so that now "old" and "new" have the same amounts of closures.
Reproducer
Use
word-levelandCombinedrenderer to test.