Class Decorator API #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfhbrook
force-pushed
the
81-class-decorator-api
branch
from
a1f02e4
to
2046f6f
Compare
jfhbrook
force-pushed
the
81-class-decorator-api
branch
from
2046f6f
to
7c0eedb
Compare
|
It means i can use |
|
correct, if you use this API then your event handlers will have a reference to |
|
awesome ! Do you have any plan to merge these changes? |
|
yeah I think so, just maybe not this week. One challenge with this project is I don't have anyone to spot me but have enough users that having to fix stuff in post kinda sucks. So what I do instead is give myself time to forget about it and review later. But code reviews from interested parties definitely help! |
|
I want to do so but i am not as good as you did. LOL |
|
hey, I know people are shy about code review but seriously anything helps! there's no such thing as dumb feedback! |
|
Ok, i will continue follow this project and try to help it. |
jfhbrook
commented
Aug 17, 2021
|
i already add |
* Set up virtualenv, pyright and isort * Run isort * Passing type annotations for base.py * action to run type checks * Alas! * Happy type checker for trio * MOST of the library is type-checking * working, non-cranky type annotations for uplift laul * Type check the tests, cause an explosion * Clean up requirements.txt * tests type-checking * py.typed file * tests and linting happy * Update build * obvious action bugfix * trailing comma * remove inconsequential and angry type annotation * Ignore type issues w asyncio import * messy typecast * anyway thats when I started blasting * carnage! * uplift bugfixes * update pytest * bye 3.6
jfhbrook
added a commit
that referenced
this pull request
Jan 12, 2022
* Add class decorator API * Add autofunctions for pyee.cls * Remove travis file * docs: Fix a few typos (#91) * Type Annotations (#97) * Set up virtualenv, pyright and isort * Run isort * Passing type annotations for base.py * action to run type checks * Alas! * Happy type checker for trio * MOST of the library is type-checking * working, non-cranky type annotations for uplift laul * Type check the tests, cause an explosion * Clean up requirements.txt * tests type-checking * py.typed file * tests and linting happy * Update build * obvious action bugfix * trailing comma * remove inconsequential and angry type annotation * Ignore type issues w asyncio import * messy typecast * anyway thats when I started blasting * carnage! * uplift bugfixes * update pytest * bye 3.6 * type annotations for cls Co-authored-by: Tim Gates <tim.gates@iress.com>
jfhbrook
added a commit
that referenced
this pull request
Jan 12, 2022
* Class Decorator API (#84) * Add class decorator API * Add autofunctions for pyee.cls * Remove travis file * docs: Fix a few typos (#91) * Type Annotations (#97) * Set up virtualenv, pyright and isort * Run isort * Passing type annotations for base.py * action to run type checks * Alas! * Happy type checker for trio * MOST of the library is type-checking * working, non-cranky type annotations for uplift laul * Type check the tests, cause an explosion * Clean up requirements.txt * tests type-checking * py.typed file * tests and linting happy * Update build * obvious action bugfix * trailing comma * remove inconsequential and angry type annotation * Ignore type issues w asyncio import * messy typecast * anyway thats when I started blasting * carnage! * uplift bugfixes * update pytest * bye 3.6 * type annotations for cls Co-authored-by: Tim Gates <tim.gates@iress.com> * added function that returns an array listing the events * ee.event_names tested and passing Now that there are some asserts for the value of event_names, we can see what issue @leirons was running into with `new_listener`. It turns out the issue ran pretty deep. Internally, pyee used to use a defaultdict to store events. This was mildly convenient for implementing on and emit, but it also meant that event names were added after an emit, even if there were no handlers. OK, so you patch it to use a regular dict and do the bookkeeping manually. But there's another reason an event might show up even if it has no handlers: pyee doesn't make an effort to clean up the OrderedDicts which contain the actual handlers. To solve this, I removed the defaultdict (so no event after an emit) and added a step on listener removal to clean up the OrderedDict. * Make event_names return a set instead of a list Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Ivan <grecigor11@gmail.com>
|
I came to a use case where I need to emit an event on the evented class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes #81 by adding a class decorator API for binding events to methods prior to class instantiation.
I'm not in a rush to merge this and I'm not confident in this API so I'm going to leave this up to give people a chance to comment on it. If people really want it I can merge/release.