ee.event_names #99
Merged
ee.event_names #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add class decorator API * Add autofunctions for pyee.cls * Remove travis file * docs: Fix a few typos (#91) * Type Annotations (#97) * Set up virtualenv, pyright and isort * Run isort * Passing type annotations for base.py * action to run type checks * Alas! * Happy type checker for trio * MOST of the library is type-checking * working, non-cranky type annotations for uplift laul * Type check the tests, cause an explosion * Clean up requirements.txt * tests type-checking * py.typed file * tests and linting happy * Update build * obvious action bugfix * trailing comma * remove inconsequential and angry type annotation * Ignore type issues w asyncio import * messy typecast * anyway thats when I started blasting * carnage! * uplift bugfixes * update pytest * bye 3.6 * type annotations for cls Co-authored-by: Tim Gates <tim.gates@iress.com>
Now that there are some asserts for the value of event_names, we can see what issue @leirons was running into with `new_listener`. It turns out the issue ran pretty deep. Internally, pyee used to use a defaultdict to store events. This was mildly convenient for implementing on and emit, but it also meant that event names were added after an emit, even if there were no handlers. OK, so you patch it to use a regular dict and do the bookkeeping manually. But there's another reason an event might show up even if it has no handlers: pyee doesn't make an effort to clean up the OrderedDicts which contain the actual handlers. To solve this, I removed the defaultdict (so no event after an emit) and added a step on listener removal to clean up the OrderedDict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a light rework of #96. I added a docstring and tests, and I debugged the issue with new_listener.
For more details on what I changed, see: c25cf56
cc @leirons