Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to verify failing audit command for yarn v1 #1773

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Add test to verify failing audit command for yarn v1 #1773

merged 5 commits into from
Jan 19, 2023

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Dec 12, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/jfrog-cli-core#637

@RobiNino RobiNino added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Dec 12, 2022
@RobiNino RobiNino requested a review from eyalbe4 December 12, 2022 13:34
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2022
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Dec 12, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2022
@RobiNino RobiNino marked this pull request as draft December 12, 2022 15:12
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Dec 12, 2022
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 12, 2022
@RobiNino RobiNino marked this pull request as ready for review December 12, 2022 15:58
@RobiNino RobiNino temporarily deployed to frogbot January 5, 2023 09:57 — with GitHub Actions Inactive
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jan 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 17, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

eyalbe4
eyalbe4 requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how we can replace this 5MB file which is part of the testdata with a smaller file.

image

@RobiNino
Copy link
Contributor Author

As we discussed, decided to leave the file as it is

@RobiNino RobiNino merged commit 8bd72ef into jfrog:dev Jan 19, 2023
sarao1310 pushed a commit to sarao1310/jfrog-cli that referenced this pull request Apr 17, 2023
@RobiNino @sarao1310
Add test to verify failing audit command for yarn v1 (jfrog#1773)
a7de561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @eyalbe4