Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command - Transfer config merge #1802

Merged
merged 39 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
bdfa025
update dependencies
sverdlov93 Jan 10, 2023
fb17cb6
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into transfe…
sverdlov93 Jan 10, 2023
4403f89
update dependencies
sverdlov93 Jan 10, 2023
d10b4de
update dependencies
sverdlov93 Jan 10, 2023
a6faaf0
update dependencies
sverdlov93 Jan 10, 2023
f9b8da9
update dependencies
sverdlov93 Jan 10, 2023
ad6201a
update dependencies
sverdlov93 Jan 10, 2023
f3ef693
update dependencies
sverdlov93 Jan 10, 2023
372a288
update dependencies
sverdlov93 Jan 10, 2023
4d2be58
update dependencies
sverdlov93 Jan 10, 2023
8b645d2
update dependencies
sverdlov93 Jan 11, 2023
287df53
update dependencies
sverdlov93 Jan 11, 2023
5266cf5
update dependencies
sverdlov93 Jan 11, 2023
0ef75fb
update dependencies
sverdlov93 Jan 12, 2023
46dc14d
update dependencies
sverdlov93 Jan 16, 2023
9821087
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into transfe…
sverdlov93 Jan 16, 2023
d3880fb
update dependencies
sverdlov93 Jan 16, 2023
a7cd334
update dependencies
sverdlov93 Jan 16, 2023
d471ef2
update dependencies
sverdlov93 Jan 16, 2023
bc24099
update dependencies
sverdlov93 Jan 16, 2023
a2fa2dc
update dependencies
sverdlov93 Jan 16, 2023
3e210bf
update dependencies
sverdlov93 Jan 16, 2023
97d0348
update dependencies
sverdlov93 Jan 16, 2023
dd0adbb
update dependencies
sverdlov93 Jan 17, 2023
3a91c87
update dependencies
sverdlov93 Jan 17, 2023
dd4c9a7
update dependencies
sverdlov93 Jan 17, 2023
9314c3d
update dependencies
sverdlov93 Jan 17, 2023
e19950c
update dependencies
sverdlov93 Jan 17, 2023
fbc8d11
update dependencies
sverdlov93 Jan 17, 2023
e662717
update dependencies
sverdlov93 Jan 17, 2023
407787c
update dependencies
sverdlov93 Jan 17, 2023
1a8438b
update dependencies
sverdlov93 Jan 17, 2023
8a12626
update dependencies
sverdlov93 Jan 17, 2023
e637b17
update dependencies
sverdlov93 Jan 18, 2023
f274bb4
update dependencies
sverdlov93 Jan 18, 2023
2614ce8
update dependencies
sverdlov93 Jan 19, 2023
e20a3f9
update dependencies
sverdlov93 Jan 19, 2023
f10e27d
update dependencies
sverdlov93 Jan 19, 2023
561e149
update dependencies
sverdlov93 Jan 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 57 additions & 6 deletions artifactory/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/replication"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/repository"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/transfer"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/transferconfig"
transferconfigcore "github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/transferconfig"
transferfilescore "github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/transferfiles"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/usersmanagement"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils"
Expand All @@ -44,7 +44,6 @@ import (
"github.com/jfrog/jfrog-cli/docs/artifactory/buildpromote"
"github.com/jfrog/jfrog-cli/docs/artifactory/buildpublish"
"github.com/jfrog/jfrog-cli/docs/artifactory/buildscan"
"github.com/jfrog/jfrog-cli/docs/artifactory/configtransfer"
copydocs "github.com/jfrog/jfrog-cli/docs/artifactory/copy"
curldocs "github.com/jfrog/jfrog-cli/docs/artifactory/curl"
"github.com/jfrog/jfrog-cli/docs/artifactory/delete"
Expand Down Expand Up @@ -93,6 +92,8 @@ import (
"github.com/jfrog/jfrog-cli/docs/artifactory/repoupdate"
"github.com/jfrog/jfrog-cli/docs/artifactory/search"
"github.com/jfrog/jfrog-cli/docs/artifactory/setprops"
"github.com/jfrog/jfrog-cli/docs/artifactory/transferconfig"
"github.com/jfrog/jfrog-cli/docs/artifactory/transferconfigmerge"
"github.com/jfrog/jfrog-cli/docs/artifactory/transferfiles"
"github.com/jfrog/jfrog-cli/docs/artifactory/transfersettings"
"github.com/jfrog/jfrog-cli/docs/artifactory/upload"
Expand Down Expand Up @@ -959,15 +960,27 @@ func GetCommands() []cli.Command {
{
Name: "transfer-config",
Flags: cliutils.GetCommandFlags(cliutils.TransferConfig),
Usage: configtransfer.GetDescription(),
HelpName: corecommon.CreateUsage("rt transfer-config", configtransfer.GetDescription(), configtransfer.Usage),
UsageText: configtransfer.GetArguments(),
Usage: transferconfig.GetDescription(),
HelpName: corecommon.CreateUsage("rt transfer-config", transferconfig.GetDescription(), transferconfig.Usage),
UsageText: transferconfig.GetArguments(),
ArgsUsage: common.CreateEnvVars(),
BashComplete: corecommon.CreateBashCompletionFunc(),
Action: func(c *cli.Context) error {
return transferConfigCmd(c)
},
},
{
Name: "transfer-config-merge",
Flags: cliutils.GetCommandFlags(cliutils.TransferConfigMerge),
Usage: transferconfigmerge.GetDescription(),
HelpName: corecommon.CreateUsage("rt transfer-config-merge", transferconfigmerge.GetDescription(), transferconfigmerge.Usage),
UsageText: transferconfigmerge.GetArguments(),
ArgsUsage: common.CreateEnvVars(),
BashComplete: corecommon.CreateBashCompletionFunc(),
Action: func(c *cli.Context) error {
return transferConfigMergeCmd(c)
},
},
{
Name: "transfer-files",
Flags: cliutils.GetCommandFlags(cliutils.TransferFiles),
Expand Down Expand Up @@ -2329,7 +2342,7 @@ func transferConfigCmd(c *cli.Context) error {
}

// Run transfer config command
transferConfigCmd := transferconfig.NewTransferConfigCommand(sourceServerDetails, targetServerDetails).SetForce(c.Bool(cliutils.Force)).
transferConfigCmd := transferconfigcore.NewTransferConfigCommand(sourceServerDetails, targetServerDetails).SetForce(c.Bool(cliutils.Force)).
SetVerbose(c.Bool(cliutils.Verbose)).SetPreChecks(c.Bool(cliutils.PreChecks)).SetWorkingDir(c.String(cliutils.WorkingDir))
includeReposPatterns, excludeReposPatterns := getTransferIncludeExcludeRepos(c)
transferConfigCmd.SetIncludeReposPatterns(includeReposPatterns)
Expand All @@ -2338,6 +2351,33 @@ func transferConfigCmd(c *cli.Context) error {
return transferConfigCmd.Run()
}

func transferConfigMergeCmd(c *cli.Context) error {
if c.NArg() != 2 {
return cliutils.WrongNumberOfArgumentsHandler(c)
}

// Get source artifactory server
sverdlov93 marked this conversation as resolved.
Show resolved Hide resolved
sourceServerDetails, err := coreConfig.GetSpecificConfig(c.Args()[0], false, true)
if err != nil {
return err
}

// Get target artifactory server
sverdlov93 marked this conversation as resolved.
Show resolved Hide resolved
targetServerDetails, err := coreConfig.GetSpecificConfig(c.Args()[1], false, true)
if err != nil {
return err
}

// Run transfer config command
includeReposPatterns, excludeReposPatterns := getTransferIncludeExcludeRepos(c)
includeProjectsPatterns, excludeProjectsPatterns := getTransferIncludeExcludeProjects(c)
transferConfigMergeCmd := transferconfigcore.NewTransferConfigMergeCommand(sourceServerDetails, targetServerDetails).
SetIncludeReposPatterns(includeReposPatterns).SetExcludeReposPatterns(excludeReposPatterns).
SetIncludeProjectsPatterns(includeProjectsPatterns).SetExcludeProjectsPatterns(excludeProjectsPatterns)
_, err = transferConfigMergeCmd.Run()
sverdlov93 marked this conversation as resolved.
Show resolved Hide resolved
return err
}

func dataTransferPluginInstallCmd(c *cli.Context) error {
// Get the Artifactory serverID from the argument or use default if not exists
serverID := ""
Expand Down Expand Up @@ -2423,6 +2463,17 @@ func getTransferIncludeExcludeRepos(c *cli.Context) (includeReposPatterns, exclu
return
}

func getTransferIncludeExcludeProjects(c *cli.Context) (includeProjectsPatterns, excludeProjectsPatterns []string) {
const patternSeparator = ";"
if c.IsSet(cliutils.IncludeProjects) {
includeProjectsPatterns = strings.Split(c.String(cliutils.IncludeProjects), patternSeparator)
}
if c.IsSet(cliutils.ExcludeProjects) {
excludeProjectsPatterns = strings.Split(c.String(cliutils.ExcludeProjects), patternSeparator)
}
return
}

func transferSettingsCmd() error {
transferSettingsCmd := transfer.NewTransferSettingsCommand()
return commands.Exec(transferSettingsCmd)
Expand Down
36 changes: 16 additions & 20 deletions artifactory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3255,22 +3255,20 @@ func TestArtifactoryDownloadByBuildUsingSimpleDownloadWithProject(t *testing.T)
initArtifactoryProjectTest(t, projectsTokenMinArtifactoryVersion)
accessManager, err := utils.CreateAccessServiceManager(serverDetails, false)
assert.NoError(t, err)
timestamp := strconv.FormatInt(time.Now().Unix(), 10)
projectKey := "prj" + timestamp[len(timestamp)-3:]
// Delete the project if already exists
deleteProjectIfExists(t, accessManager, projectKey)
deleteProjectIfExists(t, accessManager, tests.ProjectKey)

// Create new project
projectParams := accessServices.ProjectParams{
ProjectDetails: accessServices.Project{
DisplayName: "testProject " + projectKey,
ProjectKey: projectKey,
DisplayName: "testProject " + tests.ProjectKey,
ProjectKey: tests.ProjectKey,
},
}
err = accessManager.CreateProject(projectParams)
assert.NoError(t, err)
// Assign the repository to the project
err = accessManager.AssignRepoToProject(tests.RtRepo1, projectKey, true)
err = accessManager.AssignRepoToProject(tests.RtRepo1, tests.ProjectKey, true)
assert.NoError(t, err)

// Delete the build if exists
Expand All @@ -3281,14 +3279,14 @@ func TestArtifactoryDownloadByBuildUsingSimpleDownloadWithProject(t *testing.T)
buildNumberA := "123"

// Upload files with buildName, buildNumber and project flags
runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA, "--project="+projectKey)
runRt(t, "upload", "--spec="+specFileB, "--build-name="+tests.RtBuildName1, "--build-number="+buildNumberA, "--project="+tests.ProjectKey)

// Publish buildInfo with project flag
runRt(t, "build-publish", tests.RtBuildName1, buildNumberA, "--project="+projectKey)
runRt(t, "build-publish", tests.RtBuildName1, buildNumberA, "--project="+tests.ProjectKey)

// Download by project, b1 should be downloaded
runRt(t, "download", tests.RtRepo1+"/data/b1.in", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(),
"--build="+tests.RtBuildName1, "--project="+projectKey)
"--build="+tests.RtBuildName1, "--project="+tests.ProjectKey)

// Validate files are downloaded by build number
paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
Expand All @@ -3300,7 +3298,7 @@ func TestArtifactoryDownloadByBuildUsingSimpleDownloadWithProject(t *testing.T)
inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
err = accessManager.UnassignRepoFromProject(tests.RtRepo1)
assert.NoError(t, err)
err = accessManager.DeleteProject(projectKey)
err = accessManager.DeleteProject(tests.ProjectKey)
assert.NoError(t, err)
cleanArtifactoryTest()
}
Expand All @@ -3309,22 +3307,20 @@ func TestArtifactoryDownloadWithEnvProject(t *testing.T) {
initArtifactoryProjectTest(t, projectsTokenMinArtifactoryVersion)
accessManager, err := utils.CreateAccessServiceManager(serverDetails, false)
assert.NoError(t, err)
timestamp := strconv.FormatInt(time.Now().Unix(), 10)
projectKey := "prj" + timestamp[len(timestamp)-3:]
// Delete the project if already exists
deleteProjectIfExists(t, accessManager, projectKey)
deleteProjectIfExists(t, accessManager, tests.ProjectKey)

// Create new project
projectParams := accessServices.ProjectParams{
ProjectDetails: accessServices.Project{
DisplayName: "testProject " + projectKey,
ProjectKey: projectKey,
DisplayName: "testProject " + tests.ProjectKey,
ProjectKey: tests.ProjectKey,
},
}
err = accessManager.CreateProject(projectParams)
assert.NoError(t, err)
// Assign the repository to the project
err = accessManager.AssignRepoToProject(tests.RtRepo1, projectKey, true)
err = accessManager.AssignRepoToProject(tests.RtRepo1, tests.ProjectKey, true)
assert.NoError(t, err)

// Delete the build if exists
Expand All @@ -3337,7 +3333,7 @@ func TestArtifactoryDownloadWithEnvProject(t *testing.T) {
defer setEnvCallBack()
setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.BuildNumber, buildNumberA)
defer setEnvCallBack()
setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.Project, projectKey)
setEnvCallBack = clientTestUtils.SetEnvWithCallbackAndAssert(t, coreutils.Project, tests.ProjectKey)
defer setEnvCallBack()
// Upload files with buildName, buildNumber and project flags
runRt(t, "upload", "--spec="+specFileB)
Expand All @@ -3347,7 +3343,7 @@ func TestArtifactoryDownloadWithEnvProject(t *testing.T) {

// Download by project, b1 should be downloaded
runRt(t, "download", tests.RtRepo1+"/data/b1.in", filepath.Join(tests.Out, "download", "simple_by_build")+fileutils.GetFileSeparator(),
"--build="+tests.RtBuildName1, "--project="+projectKey)
"--build="+tests.RtBuildName1, "--project="+tests.ProjectKey)

// Validate files are downloaded by build number
paths, err := fileutils.ListFilesRecursiveWalkIntoDirSymlink(tests.Out, false)
Expand All @@ -3359,7 +3355,7 @@ func TestArtifactoryDownloadWithEnvProject(t *testing.T) {
inttestutils.DeleteBuild(serverDetails.ArtifactoryUrl, tests.RtBuildName1, artHttpDetails)
err = accessManager.UnassignRepoFromProject(tests.RtRepo1)
assert.NoError(t, err)
err = accessManager.DeleteProject(projectKey)
err = accessManager.DeleteProject(tests.ProjectKey)
assert.NoError(t, err)
cleanArtifactoryTest()
}
Expand Down Expand Up @@ -5046,7 +5042,7 @@ func TestAccessTokenCreate(t *testing.T) {
if *tests.JfrogAccessToken != "" {
// Use Artifactory CLI with basic auth to allow running `jfrog rt atc` without arguments
origAccessToken := *tests.JfrogAccessToken
origUsername, origPassword := tests.SetBasicAuthFromAccessToken(t)
origUsername, origPassword := tests.SetBasicAuthFromAccessToken()
defer func() {
*tests.JfrogUser = origUsername
*tests.JfrogPassword = origPassword
Expand Down
2 changes: 1 addition & 1 deletion docker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ func runKaniko(t *testing.T, imageToPush string) string {
dockerFile := "TestKanikoBuildCollect"
KanikoOutputFile := "image-file"
if *tests.JfrogAccessToken != "" {
origUsername, origPassword := tests.SetBasicAuthFromAccessToken(t)
origUsername, origPassword := tests.SetBasicAuthFromAccessToken()
defer func() {
*tests.JfrogUser = origUsername
*tests.JfrogPassword = origPassword
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package configtransfer
package transferconfig

var Usage = []string{"rt transfer-config [command options] <source-server-id> <target-server-id>"}

Expand Down
15 changes: 15 additions & 0 deletions docs/artifactory/transferconfigmerge/help.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package transferconfigmerge

var Usage = []string{"rt transfer-config-merge [command options] <source-server-id> <target-server-id>"}

func GetDescription() string {
return "Merge repositories and projects from source Artifactory server to target Artifactory server and print merge conflicts CSV"
sverdlov93 marked this conversation as resolved.
Show resolved Hide resolved
}

func GetArguments() string {
return ` source-server-id
The source server ID. The configuration will be exported from this server.

target-server-id
The target server ID. The configuration will be imported to this server.`
}
7 changes: 4 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ require (
github.com/agnivade/levenshtein v1.1.1
github.com/buger/jsonparser v1.1.1
github.com/go-git/go-git/v5 v5.5.1
github.com/gocarina/gocsv v0.0.0-20221216233619-1fea7ae8d380
github.com/jfrog/build-info-go v1.8.5
github.com/jfrog/gofrog v1.2.5
github.com/jfrog/jfrog-cli-core/v2 v2.27.0
Expand Down Expand Up @@ -51,12 +52,12 @@ require (
github.com/fsnotify/fsnotify v1.6.0 // indirect
github.com/go-git/gcfg v1.5.0 // indirect
github.com/go-git/go-billy/v5 v5.3.1 // indirect
github.com/gocarina/gocsv v0.0.0-20221216233619-1fea7ae8d380 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang-jwt/jwt/v4 v4.4.3 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/golang/snappy v0.0.2 // indirect
github.com/goldeneggg/structil v0.9.1 // indirect
github.com/google/uuid v1.3.0 // indirect
github.com/gookit/color v1.5.2 // indirect
github.com/hashicorp/hcl v1.0.0 // indirect
Expand Down Expand Up @@ -125,8 +126,8 @@ require (

// replace github.com/jfrog/build-info-go => github.com/jfrog/build-info-go v1.8.5-0.20230103131235-4993ad739dc6

// replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.24.6-0.20230102092554-c56fc329c8fc
replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.25.1-0.20230111140228-ba27f78829cd

// replace github.com/jfrog/jfrog-cli-core/v2 => github.com/jfrog/jfrog-cli-core/v2 v2.26.1-0.20230103131355-15bc81e82c09
replace github.com/jfrog/jfrog-cli-core/v2 => github.com/sverdlov93/jfrog-cli-core/v2 v2.0.2-0.20230112121735-fe144cd1f0c5

// replace github.com/jfrog/gofrog => github.com/jfrog/gofrog v1.2.5-0.20221107113836-a4c9225c690e
10 changes: 6 additions & 4 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,8 @@ github.com/golang/protobuf v1.5.2 h1:ROPKBNFfQgOUMifHyP+KYbvpjbdoFNs+aK7DXlji0Tw
github.com/golang/protobuf v1.5.2/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY=
github.com/golang/snappy v0.0.2 h1:aeE13tS0IiQgFjYdoL8qN3K1N2bXXtI6Vi51/y7BpMw=
github.com/golang/snappy v0.0.2/go.mod h1:/XxbfmMg8lxefKM7IXC3fBNl/7bRcc72aCRzEWrmP2Q=
github.com/goldeneggg/structil v0.9.1 h1:vIllvysxqBUAOSsfU2iDqryYWotg3yyyYFB7dishelk=
github.com/goldeneggg/structil v0.9.1/go.mod h1:+Ph1oPhDq6U2IyIo47cG6XnkeiIY8DaPjCIW7sazzRg=
github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ=
github.com/google/btree v1.0.0/go.mod h1:lNA+9X1NB3Zf8V7Ke586lFgjr2dZNuvo3lPJSGZ5JPQ=
github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M=
Expand Down Expand Up @@ -528,10 +530,8 @@ github.com/jfrog/build-info-go v1.8.5 h1:NXk0LrgGZzaK1QwHS8wMjvyLob9iLwi8//80vja
github.com/jfrog/build-info-go v1.8.5/go.mod h1:iSTj26qEX3eUtyAGMH0qKsW4WJT+MceYxLWP9FfiAq4=
github.com/jfrog/gofrog v1.2.5 h1:jCgJC0iGQ8bU7jCC+YEFJTNINyngApIrhd8BjZAVRIE=
github.com/jfrog/gofrog v1.2.5/go.mod h1:o00tSRff6IapTgaCMuX1Cs9MH08Y1JqnsKgRtx91Gc4=
github.com/jfrog/jfrog-cli-core/v2 v2.27.0 h1:44uv1shgsKJ+3EAZLfwcDveBLcLkJBB6B8UCRcO2PlQ=
github.com/jfrog/jfrog-cli-core/v2 v2.27.0/go.mod h1:lD9vRmJeggZFjNOPRigtcw5gl17lm29PQJRvmnO9UbA=
github.com/jfrog/jfrog-client-go v1.25.0 h1:baSjeB9OrE4+bFtulyD0IPRkTt5Ynr7XGsTvtlIUztg=
github.com/jfrog/jfrog-client-go v1.25.0/go.mod h1:3UIKpuDbH+CeWXHrIqnYPqZmG0+0lXnFh5WJ7qN3jAM=
github.com/jfrog/jfrog-client-go v1.25.1-0.20230111140228-ba27f78829cd h1:SajFXbUnfdxrhtJHoNE4TQ0ku9JLkzV842oTdtyrlI8=
github.com/jfrog/jfrog-client-go v1.25.1-0.20230111140228-ba27f78829cd/go.mod h1:3UIKpuDbH+CeWXHrIqnYPqZmG0+0lXnFh5WJ7qN3jAM=
github.com/jmespath/go-jmespath v0.0.0-20160202185014-0b12d6b521d8/go.mod h1:Nht3zPeWKUH0NzdCt2Blrr5ys8VGpn0CEB0cQHVjt7k=
github.com/jmespath/go-jmespath v0.0.0-20160803190731-bd40a432e4c7/go.mod h1:Nht3zPeWKUH0NzdCt2Blrr5ys8VGpn0CEB0cQHVjt7k=
github.com/joefitzgerald/rainbow-reporter v0.1.0/go.mod h1:481CNgqmVHQZzdIbN52CupLJyoVwB10FQ/IQlF1pdL8=
Expand Down Expand Up @@ -832,6 +832,8 @@ github.com/stretchr/testify v1.8.1 h1:w7B6lhMri9wdJUVmEZPGGhZzrYTPvgJArz7wNPgYKs
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
github.com/subosito/gotenv v1.4.1 h1:jyEFiXpy21Wm81FBN71l9VoMMV8H8jG+qIK3GCpY6Qs=
github.com/subosito/gotenv v1.4.1/go.mod h1:ayKnFf/c6rvx/2iiLrJUk1e6plDbT3edrFNGqEflhK0=
github.com/sverdlov93/jfrog-cli-core/v2 v2.0.2-0.20230112121735-fe144cd1f0c5 h1:3iDvH+myby+7pS0ixmdh+WDL5UTGC4uqoU+qRRi7H98=
github.com/sverdlov93/jfrog-cli-core/v2 v2.0.2-0.20230112121735-fe144cd1f0c5/go.mod h1:xv+SOpthS2drccwmQbE0Nj/yMvwXg18Py0IUltnQlXk=
github.com/syndtr/gocapability v0.0.0-20170704070218-db04d3cc01c8/go.mod h1:hkRG7XYTFWNJGYcbNJQlaLq0fg1yr4J4t/NcTQtrfww=
github.com/syndtr/gocapability v0.0.0-20180916011248-d98352740cb2/go.mod h1:hkRG7XYTFWNJGYcbNJQlaLq0fg1yr4J4t/NcTQtrfww=
github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635/go.mod h1:hkRG7XYTFWNJGYcbNJQlaLq0fg1yr4J4t/NcTQtrfww=
Expand Down
5 changes: 4 additions & 1 deletion inttestutils/transfer.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ const (
// targetArtifactoryCli - Target Artifactory CLI
func CreateTargetRepos(targetArtifactoryCli *tests.JfrogCli) {
log.Info("Creating repositories in target Artifactory...")
for _, template := range tests.CreatedNonVirtualRepositories {
for repoName, template := range tests.CreatedNonVirtualRepositories {
if *repoName == tests.DockerRemoteRepo {
sverdlov93 marked this conversation as resolved.
Show resolved Hide resolved
continue
}
repoTemplate := filepath.Join("testdata", template)
templateVars := fmt.Sprintf("--vars=REPO1=%s;REPO2=%s;MAVEN_REPO1=%s;MAVEN_REMOTE_REPO=%s",
tests.RtRepo1, tests.RtRepo2, tests.MvnRepo1, tests.MvnRemoteRepo)
Expand Down
2 changes: 1 addition & 1 deletion main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func createJfrogHomeConfig(t *testing.T, encryptPassword bool) {
assert.NoError(t, err)
}
*tests.JfrogUrl = utils.AddTrailingSlashIfNeeded(*tests.JfrogUrl)
err = tests.NewJfrogCli(execMain, "jfrog config", credentials).Exec("add", "default", "--interactive=false", "--artifactory-url="+*tests.JfrogUrl+tests.ArtifactoryEndpoint, "--xray-url="+*tests.JfrogUrl+tests.XrayEndpoint, "--enc-password="+strconv.FormatBool(encryptPassword))
err = tests.NewJfrogCli(execMain, "jfrog config", credentials).Exec("add", "default", "--interactive=false", "--url="+*tests.JfrogUrl, "--enc-password="+strconv.FormatBool(encryptPassword))
assert.NoError(t, err)
}

Expand Down
Loading