Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin install - return error if plugin not found #1826

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Plugin install - return error if plugin not found #1826

merged 1 commit into from
Feb 7, 2023

Conversation

talarian1
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Before this PR, if the plugin download failed due to a 404 error, the error that was mistakenly returned was the one from the failed chmod command.

@talarian1 talarian1 added the bug Something isn't working label Feb 6, 2023
@talarian1 talarian1 requested review from eyalbe4 and RobiNino February 6, 2023 10:58
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Feb 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 6, 2023
@talarian1 talarian1 merged commit 61f704d into jfrog:dev Feb 7, 2023
sarao1310 pushed a commit to sarao1310/jfrog-cli that referenced this pull request Apr 17, 2023
@talarian1 @sarao1310
Plugin install - return error if plugin not found (jfrog#1826)
caab845
@talarian1 talarian1 deleted the fix-plugin-install-not-found branch May 24, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talarian1 @eyalbe4