Prefer true, false keywords to macros of same.

lib/addr_match.c

@@ -159,7 +159,7 @@ parr *bp_block_match(const struct bp_block *block,
 
 err_out:
 	BN_clear_free(&tmp_mask);
-	parr_free(arr, TRUE);
+	parr_free(arr, true);
 	return NULL;
 }
 

lib/core.c

@@ -77,7 +77,7 @@ void bp_locator_free(struct bp_locator *locator)
 		return;
 
 	if (locator->vHave) {
-		parr_free(locator->vHave, TRUE);
+		parr_free(locator->vHave, true);
 		locator->vHave = NULL;
 	}
 }
@@ -329,7 +329,7 @@ void bp_tx_free_vout(struct bp_tx *tx)
 	if (!tx || !tx->vout)
 		return;
 
-	parr_free(tx->vout, TRUE);
+	parr_free(tx->vout, true);
 	tx->vout = NULL;
 }
 
@@ -339,7 +339,7 @@ void bp_tx_free(struct bp_tx *tx)
 		return;
 
 	if (tx->vin) {
-		parr_free(tx->vin, TRUE);
+		parr_free(tx->vin, true);
 		tx->vin = NULL;
 	}
 
@@ -508,7 +508,7 @@ void bp_block_vtx_free(struct bp_block *block)
 			bp_tx_free(tx);
 		}
 
-		parr_free(block->vtx, TRUE);
+		parr_free(block->vtx, true);
 
 		block->vtx = NULL;
 	}

lib/message.c

@@ -126,7 +126,7 @@ cstring *ser_msg_addr(unsigned int protover, const struct msg_addr *ma)
 void msg_addr_free(struct msg_addr *ma)
 {
 	if (ma->addrs) {
-		parr_free(ma->addrs, TRUE);
+		parr_free(ma->addrs, true);
 		ma->addrs = NULL;
 	}
 }
@@ -217,7 +217,7 @@ void msg_headers_free(struct msg_headers *mh)
 			bp_block_free(block);
 		}
 
-		parr_free(mh->headers, TRUE);
+		parr_free(mh->headers, true);
 		mh->headers = NULL;
 	}
 }
@@ -343,7 +343,7 @@ void msg_vinv_free(struct msg_vinv *mv)
 		return;
 
 	if (mv->invs) {
-		parr_free(mv->invs, TRUE);
+		parr_free(mv->invs, true);
 		mv->invs = NULL;
 	}
 }

lib/script.c

@@ -79,7 +79,7 @@ parr *bsp_parse_all(const void *data_, size_t data_len)
 	return arr;
 
 err_out:
-	parr_free(arr, TRUE);
+	parr_free(arr, true);
 	return NULL;
 }
 
@@ -220,7 +220,7 @@ bool bsp_addr_parse(struct bscript_addr *addr,
 
 	addr->txtype = txtype;
 
-	parr_free(ops, TRUE);
+	parr_free(ops, true);
 	return true;
 }
 

lib/script_eval.c

@@ -1051,7 +1051,7 @@ static bool bp_script_eval(parr *stack, const cstring *script,
 
 out:
 	BN_clear_free(&bn);
-	parr_free(altstack, TRUE);
+	parr_free(altstack, true);
 	g_byte_array_unref(vfExec);
 	return rc;
 }
@@ -1111,11 +1111,11 @@ bool bp_script_verify(const cstring *scriptSig, const cstring *scriptPubKey,
 	rc = true;
 
 out:
-	parr_free(stack, TRUE);
+	parr_free(stack, true);
 	if (pubkey2)
 		cstr_free(pubkey2, true);
 	if (stackCopy)
-		parr_free(stackCopy, TRUE);
+		parr_free(stackCopy, true);
 	return rc;
 }
 

lib/serialize.c

@@ -231,7 +231,7 @@ bool deser_u256_array(parr **ao, struct const_buffer *buf)
 {
 	parr *arr = *ao;
 	if (arr) {
-		parr_free(arr, TRUE);
+		parr_free(arr, true);
 		*ao = arr = NULL;
 	}
 
@@ -262,7 +262,7 @@ bool deser_u256_array(parr **ao, struct const_buffer *buf)
 	return true;
 
 err_out:
-	parr_free(arr, TRUE);
+	parr_free(arr, true);
 	return false;
 }
 

lib/utxo.c

@@ -18,7 +18,7 @@ static void bp_utxo_free_vout(struct bp_utxo *coin)
 	if (!coin || !coin->vout)
 		return;
 
-	parr_free(coin->vout, TRUE);
+	parr_free(coin->vout, true);
 	coin->vout = NULL;
 }
 

src/blkstats.c

@@ -147,7 +147,7 @@ static void scan_txout(struct bp_txout *txout)
 	 }
 	}
 
-	parr_free(script, TRUE);
+	parr_free(script, true);
 }
 
 static void scan_tx(struct bp_tx *tx)

src/brd.c

@@ -221,7 +221,7 @@ static bool nc_conn_send(struct nc_conn *conn, const char *command,
 	buf->p = msg->str;
 	buf->len = msg->len;
 
-	cstr_free(msg, FALSE);
+	cstr_free(msg, false);
 
 	/* if write q exists, write_evt will handle output */
 	if (conn->write_q) {
@@ -1609,7 +1609,7 @@ static void shutdown_nci(struct net_child_info *nci)
 	peerman_free(nci->peers);
 	nc_conns_gc(nci, true);
 	assert(nci->conns->len == 0);
-	parr_free(nci->conns, TRUE);
+	parr_free(nci->conns, true);
 	event_base_free(nci->eb);
 }
 

src/net.c

@@ -258,7 +258,7 @@ static bool nc_conn_send(struct nc_conn *conn, const char *command,
 	buf->p = msg->str;
 	buf->len = msg->len;
 
-	cstr_free(msg, FALSE);
+	cstr_free(msg, false);
 
 	/* if write q exists, write_evt will handle output */
 	if (conn->write_q) {

src/peerman.c

@@ -22,7 +22,7 @@ static unsigned long addr_hash(const void *key)
 
 static bool addr_equal(const void *a, const void *b)
 {
-	return memcmp(a, b, 16) == 0 ? TRUE : FALSE;
+	return (memcmp(a, b, 16) == 0);
 }
 
 bool deser_peer(unsigned int protover,

src/wallet.c

@@ -41,7 +41,7 @@ static void wallet_free(struct wallet *wlt)
 	wallet_for_each_key(wlt, key)
 		bp_key_free(key);
 
-	parr_free(wlt->keys, TRUE);
+	parr_free(wlt->keys, true);
 	wlt->keys = NULL;
 
 	memset(wlt, 0, sizeof(*wlt));

test/tx-valid.c

@@ -189,12 +189,12 @@ static void runtest(bool is_valid, const char *basefn)
 		cstr_free(tx_ser, true);
 
 		if (comments->len > 0) {
-			parr_free(comments, TRUE);
+			parr_free(comments, true);
 			comments = parr_new(8, free);
 		}
 	}
 
-	parr_free(comments, TRUE);
+	parr_free(comments, true);
 	comments = NULL;
 
 	bp_hashtab_unref(input_map);

test/wallet-basics.c

@@ -138,7 +138,7 @@ static void runtest(const char *json_base_fn, const char *ser_in_fn,
 	g_array_free(mtree, TRUE);
 	g_array_free(mbranch, TRUE);
 	BN_clear_free(&tmp_mask);
-	parr_free(matches, TRUE);
+	parr_free(matches, true);
 	bpks_free(&ks);
 	bp_key_free(&key);
 	bp_block_free(&block_in);