Separate a universal load_img() method
#6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 3, 2017 12:28
…amera class, minor changes in example scripts (not finished)
…ccess and automatic download, changed version to 0.8.0.dev1, changed example script 1 (ex0_...), major restructuring in docs, included VERSION.rst
…ng.py and minor changes in inout.py, dataset.py, and calibration.py
… model_functions.py which includes mathematical function definitions relevant for piscope. Removed fitting routines from doasfov.py (which needs to be updated now)
…ion.py, doasfov.py deleted, new modules: cellcalib.py, doascalib.py, further developed doas calibration, 90% finished
…class, re-organised scripts, further developed doascalib.py
…aved as fits now, further developed example scripts
…lified Camera class init, new script (ex7) for combined DOAS and cell calibration
…ge in plot function of FOV class
… lines, added features to LineOnImage (e.g. offset, orientation of normal vector)
…images, with x index being the time and y data being the extracted profiles (see processing.py, class ProfileTimeSeriesImg), minor changes on example scripts
…e (normal vector determination)
…features to classes LineOnImage and ProfileTimeSeriesImg, minor changes in examples
…les (the copyright text was copied and adapted from the source files of the flexDOAS library (Author: G. Kuhlmann)
… block in setup.py for reading in of README.rst
…ume distance retr.); improved performance and convenience of cellcalib.py module; worked on docs
…n docs; minor changes in some of the examples
…st for automised correction of signal dilution). See Changelog for information
… list (attr: bg_which='list')
…images and sphinx 1.6.x
`load_img` is used in many methods e.g. `load()`, `load_next()`, `activate_tau_mode()`, ... Separating has two advantages: 1) Reduced code redundance and improved clearity 2) `load_img()`can be redefined in child classes without the need of redefining every method
|
I close this request due to multiple and difficult to solve conflicts arising from diverging parallel development in the past. Since then Pyplis has undergone many fundamental changes and major improvements. I suggest to review individual commits of request and compare with current Pyplis version and, if applicable, submit smaller, individual requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_imgis used in many methods e.g.load(),load_next(),activate_tau_mode(), ...Separating has two advantages: 1) Reduced code redundance and improved clearity 2)
load_img()can be redefined in child classes without the need of redefining every method