Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ace editor? #427

Open
lmullen opened this issue May 28, 2014 · 5 comments
Open

Use Ace editor? #427

lmullen opened this issue May 28, 2014 · 5 comments

Comments

@lmullen
Copy link
Contributor

lmullen commented May 28, 2014

I've added the Ace editor to my installation of Gitit to use with Vim mode. Would you be interested in a pull request that added Ace? I've implemented it as a hack with my own idiosyncratic preferences, but I can add it with sane defaults if you wanted to ship it with gitit.

borteqsiiaevt5u

@jgm
Copy link
Owner

jgm commented May 28, 2014

I'm not crazy about making it the default, or about distributing
the ace source with gitit (since it's a huge library). But it might
make sense to add a config option to use ace. The default could
simply be to load ace from the jsdelivr CDN,
http://www.jsdelivr.com/#!ace
and then gitit wouldn't need to ship ace sources...

@Morgul
Copy link

Morgul commented May 28, 2014

I would love that. Either code mirror or ace are great choices; I write a lot of technical docs in a wiki, so having useful tab support and syntax highlighting are huge wins for me.

@lmullen
Copy link
Contributor Author

lmullen commented May 28, 2014

I'll implement this as you suggest, making Ace opt-in through the configuration file and using the CDN, and you can take a look to see whether you like it.

@trdlo
Copy link

trdlo commented Sep 1, 2014

@lmullen could you provide your hacked code, if the pull request is not on it's way? i am rather lazy figuring it out myself as how to do it, especially when someone else already managed to get it working himself

@lmullen
Copy link
Contributor Author

lmullen commented Sep 1, 2014

Everything you need should be in this gist:
https://gist.github.com/lmullen/e2d2d4aabf84220c517a

On Mon, Sep 1, 2014 at 3:17 AM, trdlo notifications@github.com wrote:

@lmullen https://github.com/lmullen could you provide your hacked code,
if the pull request is not on it's way? i am rather lazy figuring it out
myself as how to do it, especially when someone else already managed to get
it working himself


Reply to this email directly or view it on GitHub
#427 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants