Safe Haskell compatability #493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From a brief look at the API, it all seems safe, so I'm currently labeling all the modules Trustworthy. TODO: some of the modules may (but are unlikely to) be Safe. In a later verison, when parsec etc. are labeled Trustworthy, most of the modules exported by this package can conceivably simply be Safe.
trustworthy
|
I don't know anything about these new GHC extensions. Could you explain what is meant by the Trustworthy classification, and what impact it has? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes pretty much every module of pandoc Trustworthy. I hope to convince the authors of the packages pandoc depends on to make their packages Trustworthy, at which point we can turn many of the Trustworthy modules to Safe. If there is some particular module that is not safe, please let me know.