Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/utils): extend support for aarch64 to Linux #2

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Dec 10, 2023

In the original change, it was macOS that was covered, but Virtus Lab actually ships aarch64/arm64-ready releases for Linux systems too. Besides using them natively, extending the support for those could come handy when running Linux containers on macOS.

@jiahuili430
Copy link
Owner

Thanks for your contribution, could you run ./scripts/shfmt.bash and force push?

@pgj
Copy link
Contributor Author

pgj commented Dec 11, 2023

Sure. Let me fix this. I have not noticed the CI errors.

In the original change, it was macOS that was covered, but Virtus
Lab actually ships aarch64/arm64-ready releases for Linux systems
too.  Besides using them natively, extending the support for those
could come handy when running Linux containers on macOS.
@pgj pgj force-pushed the fix/lib_utils/aarch64-linux branch from 4a66a9c to 4618631 Compare December 11, 2023 14:03
Copy link
Owner

@jiahuili430 jiahuili430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you!

@jiahuili430 jiahuili430 merged commit b8ee13d into jiahuili430:main Dec 11, 2023
4 checks passed
@pgj pgj deleted the fix/lib_utils/aarch64-linux branch December 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants