Skip to content

Conversation

jamesadevine
Copy link
Collaborator

As per documentation, an USBIP_CMD_UNLINK response should return 24 bytes of padding.

@coveralls
Copy link

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4114585569

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 41.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 4061119800: -0.08%
Covered Lines: 533
Relevant Lines: 1280

💛 - Coveralls

@jiegec jiegec merged commit a1e6f1c into jiegec:master Feb 7, 2023
@jiegec
Copy link
Owner

jiegec commented Feb 7, 2023

Wow, the Linux documentation finally provides the structure definition. When I was writing the library, the documentation was so poor that I had to read through linux kernel code.

@jamesadevine
Copy link
Collaborator Author

@jiegec It might be good to review the other calls too based on the documentation. I'm pretty sure there is another case that needs to be handled with USBIP_CMD_UNLINK. See status description below:

image

@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 4114585569

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 42.365%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 4061119800: 0.6%
Covered Lines: 516
Relevant Lines: 1218

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4114468553

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 42.33%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
../../../.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.25.0/src/io/util/write_int.rs 1 72.22%
Totals Coverage Status
Change from base Build 4061119800: 0.6%
Covered Lines: 516
Relevant Lines: 1219

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants