Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/userlist: add genre/demographic IDs to URL #369

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

purarue
Copy link
Contributor

@purarue purarue commented Oct 21, 2021

On a request like https://api.jikan.moe/v3/user/QCTFW/animelist

Currently it looks like:

{
  "genres": [
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Comedy",
          "url": "https://myanimelist.net/anime/genre/Comedy"
        },
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Romance",
          "url": "https://myanimelist.net/anime/genre/Romance"
        },
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Slice of Life",
          "url": "https://myanimelist.net/anime/genre/Slice of Life"
        }
      ],
      "demographics": [
        {
          "mal_id": 0,
          "type": "anime",
          "name": "Shounen",
          "url": "https://myanimelist.net/anime/genre/Shounen"
        }
      ]
}

Since the mal id isn't put into the MalUrl object, so it can't parse it out of the URL

Just added it as part of the URL, previous URLs weren't valid

@purarue purarue changed the title bugfix: add genre/demographic IDs to MalUrl object bugfix/userlist: add genre/demographic IDs to URL Oct 21, 2021
@irfan-dahir irfan-dahir merged commit 1a8e0ab into jikan-me:master Oct 21, 2021
@irfan-dahir
Copy link
Collaborator

irfan-dahir commented Oct 21, 2021

Thank you!

Edit: Pushed the update to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants