Fix 'NoneType' object is not iterable
when using __in
with empty list.
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem case:
model.objects.filter(<field>__in=[])
produces a'NoneType' object is not iterable
exception.Cause:
get_prep_lookup
in_NetAddressField
returnsNone
ifvalue
is falsy.Change:
Remove early return in
get_prep_lookup
. Superclass'sget_prep_lookup
will be called with the value instead.Added unit test for
__in
empty list case.An alternative (neater?) unit test would be simply performing a
self.qs.filter(field__in=[])
and checking it returns an empty query set.