-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmounted datasets lead to confusing gaps in output #5
Comments
There's an implementation that shows the unique-after-the-previous-segments, which would turn the second example into
If we're going to keep doing 2-competing-implementations 😺 then an alternative would be to output the missing segments on lines of their own with no data. Neither seems particularly visually appealing, though. I find the extra name-segments to "fill in the gaps" distracting. |
I think having the missing segments on their own line is the way to go, then you're not having to switch between two different ways of reading the output and less likely to get confused by more complex hierarchies. e.g:
vs:
The latter makes |
Fixes jimsalterjrs#5 This finds the longest common prefix of path segments since the last and current dataset and prints any up to the final segment that have been missed. For example, a root mount at rpool/ROOT/default would previously be displayed thus: dataset default ... This ensures the path leading up to it have their own lines: dataset rpool ROOT default ... I believe this to be a more consistent fix than the one proposed in jimsalterjrs#6 where intermediates are formatted on a single line.
Wait, I could have sworn I branched that off main. Gah. I'll get to it later, I need to go make food. |
Fixes jimsalterjrs#5 This finds the longest common prefix of path segments since the last and current dataset and prints any up to the final segment that have been missed. For example, a root mount at rpool/ROOT/default would previously be displayed thus: dataset default ... This ensures the path leading up to it have their own lines: dataset rpool ROOT default ... I believe this to be a more consistent fix than the one proposed in jimsalterjrs#6 where intermediates are formatted on a single line.
Stats for unmounted datasets aren't exported, so you can end up with incomplete hierarchies in ioztat output. For example here
rpool
andrpool/ROOT
aren't mounted, leavingrpool/ROOT/default
without the path leading up to it:Similarly,
rpool/usr/local/poudriere/ports/default
misses the mountpoint-lesspoudriere/ports
segments:The text was updated successfully, but these errors were encountered: