Print paths for unmounted intermediate datasets #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jimsalterjrs#5 This finds the longest common prefix of path segments since the last and current dataset and prints any up to the final segment that have been missed. For example, a root mount at rpool/ROOT/default would previously be displayed thus: dataset default ... This ensures the path leading up to it have their own lines: dataset rpool ROOT default ... I believe this to be a more consistent fix than the one proposed in jimsalterjrs#6 where intermediates are formatted on a single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
This finds the longest common prefix of path segments since the last and
current dataset and prints any up to the final segment that have been
missed.
For example, a root mount at rpool/ROOT/default would previously be
displayed thus:
This ensures the path leading up to it have their own lines:
I believe this to be a more consistent fix than the one proposed in #6
where intermediates are formatted on a single line.