-
Notifications
You must be signed in to change notification settings - Fork 140
Migrate faiss search migrate to jina 0.4.1 #130
Conversation
@nan-wang should we merge this example? |
@JoanFM one moment, let me test again |
I proposed change in #138. When I created this example, I wanted to have a |
With the new |
Made some small changes in #139. I included the dockerfile folder into the example, otherwise |
@YueLiu-jina @JoanFM I saw your PRs, thanks for that.How we are going to proceed? |
You can merge both into your branch! |
fix: fix faiss search
See comment #138 (comment)
lgtm! |
LGTM! |
@YueLiu-jina can you resolve the conflict? Then I'll test again |
@bwanglzu Merged my branch, I'll give it a test again |
Still works? |
it works well, I think this PR is ready to merge |
@YueLiu-jina, it prints results? can u post a screenshot of what u get in query output? just double checking |
Good to merge then! |
This PR was aligned with issue #116 , migrate faiss search example for Jina 0.4.1 release, includes:
To run this example, you should build faiss image locally using jina 0.4.1 with Dockerfile:
And run command:
docker build -f Dockerfile -t jinaai/hub.executors.indexers.vector.faiss:latest .