Skip to content

Conversation

rmorozov
Copy link
Member

Make jinja2cpp compilable under clang 12 with -std=c++20
the problem arose from the fact that libfmt switched to consteval check of format
string(that is great, but makes us obliged to provide format_to with
constexpr format_string or fmt::runtime overload)

unfortunatelly I couldn't make it work with constexpr std::string
so multistringliteral returns std::basic_string_view except for cases
where it needs std::string

fix https://github.com/jinja2cpp/Jinja2Cpp/issues/213

the problem arose from the fact that libfmt switched to consteval check of format
string(that is great, but makes us obliged to provide format_to with
constexpr format_string or fmt::runtime overload)

unfortunatelly I couldn't make it work with constexpr std::string
so multistringliteral returns std::basic_string_view except for cases
where it needs std::string

fix #213
@rmorozov
Copy link
Member Author

unfortunately PR messed up with my experiments with clang-tidy=(

Sorry for that

@rmorozov rmorozov merged commit 5838320 into master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant