Skip to content

Do not require reflected types to be default constructible #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

Manu343726
Copy link
Contributor

@Manu343726 Manu343726 commented Oct 4, 2018

I think that using a variant there is more correct, but this quick fix does the job

@flexferrum
Copy link
Collaborator

The same again. :) Second time during this year I forget that not every object meets this requirement. boost::optional is ok for quick-fix, but I'd prefer nonstd::optional or nonstd::variant.

@flexferrum flexferrum merged commit e368425 into jinja2cpp:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants