Fix Broken Links on React and Flutter SDK Dev Guide Pages #457
Conversation
docs/dev-guide/react-native-sdk.md
Outdated
| @@ -9,7 +9,7 @@ in a customizable way which you can embed in your React Native apps. | |||
| ## Sample application using the React Native SDK | |||
|
|
|||
| If you want to see how easy integrating the Jitsi React Native SDK into a React Native application is, take a look at the<br/> | |||
| [sample applications repository](https://github.com/jitsi/jitsi-meet-sdk-samples/react-native). | |||
| [sample applications repository](https://github.com/jitsi/jitsi-meet-sdk-samples). | |||
There was a problem hiding this comment.
Could you please link the sample directly like this? https://github.com/jitsi/jitsi-meet-sdk-samples/tree/master/react-native
There was a problem hiding this comment.
@mihhu
Certainly, I can update the link directly to the corresponding folder: react-native.
However, I also recommend considering a consistent approach for the links on the ios-sdk and android-sdk pages. This will ensure a cohesive user experience while navigating through the various SDK samples.
Feel free to let me know your thoughts on this
There was a problem hiding this comment.
I see what you mean! Since IOS has multiple entries and all, I think linking the id in the page would be the better solution (e.g.. https://github.com/jitsi/jitsi-meet-sdk-samples#react-native). Could you please apply the change for all of them?
There was a problem hiding this comment.
See your point. Got you and fixed using your solution. Please review
There was a problem hiding this comment.
Hmm, that's odd, I can't see the changes. Can you please check that you've pushed them?
There was a problem hiding this comment.
@mihhu You're right. I forgot to push - my bad.
Now its pushed and ready to be reviewed
Pull Request: Fix Broken Links on React and Flutter SDK Dev Guide Pages
Description:
This PR addresses two broken links found on the following pages:
Both pages were supposed to link to the jitsi-meet-sdk-samples repository. I've updated the invalid links to correctly point to the intended repository.
Please review and merge if all looks good. Thank you!