Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backward compat for source names and multi-stream #1130

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jan 24, 2024

  • ref: Remove backward compatibility with endpoints with no source name support.
  • Remove multi stream backward compat code.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (030b8e9) 28.70% compared to head (2816a5c) 28.55%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1130      +/-   ##
============================================
- Coverage     28.70%   28.55%   -0.15%     
+ Complexity      467      463       -4     
============================================
  Files           128      128              
  Lines          7824     7732      -92     
  Branches       1071     1053      -18     
============================================
- Hits           2246     2208      -38     
+ Misses         5307     5258      -49     
+ Partials        271      266       -5     
Files Coverage Δ
...tsi/jicofo/bridge/colibri/ColibriSessionManager.kt 0.00% <ø> (ø)
...org/jitsi/jicofo/bridge/colibri/ParticipantInfo.kt 0.00% <ø> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 43.53% <ø> (+0.49%) ⬆️
...i/jicofo/conference/ParticipantInviteRunnable.java 50.31% <ø> (-0.32%) ⬇️
...c/main/kotlin/org/jitsi/jicofo/ConferenceConfig.kt 96.92% <ø> (-0.14%) ⬇️
...o/src/main/kotlin/org/jitsi/jicofo/FocusManager.kt 42.30% <ø> (+0.45%) ⬆️
...n/org/jitsi/jicofo/conference/ConferenceMetrics.kt 94.87% <ø> (-0.69%) ⬇️
.../kotlin/org/jitsi/jicofo/conference/Participant.kt 54.41% <100.00%> (+1.65%) ⬆️
...lin/org/jitsi/jicofo/conference/SourceSignaling.kt 94.73% <100.00%> (+25.98%) ⬆️
...tlin/org/jitsi/jicofo/bridge/colibri/Extensions.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030b8e9...2816a5c. Read the comment docs.

@bgrozev bgrozev merged commit 716af90 into jitsi:master Jan 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants