Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Logs the regions of bridges and participants. #202

Merged
merged 3 commits into from
Jul 6, 2017

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jun 30, 2017

No description provided.

Copy link
Member

@bbaldino bbaldino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, is there no other time where it might be interesting to log the regions involved?

@bgrozev
Copy link
Member Author

bgrozev commented Jun 30, 2017

Perhaps when a participant leaves?

@bgrozev
Copy link
Member Author

bgrozev commented Jun 30, 2017

Please don't merge this yet


sb.append("]");
logger.info(sb.toString());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra newline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logger is supposed to add one, isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, i just meant the empty line at the end of the method

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@bbaldino bbaldino merged commit 137b311 into jitsi:master Jul 6, 2017
@bgrozev bgrozev deleted the log-regions branch January 25, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants