added 1 version of all sprites, cutting sprites, and hide cursor #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesleyrs
changed the title
lesleyrs
changed the title
jjant
approved these changes
Feb 11, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: closes #16, closes #18 (not related but look here #38 (comment))
Description of changes: Added 1 version of all missing assets, I'm pretty confident they are all correct. The tool sprites are mostly 7x7 and the menu sprites at top are 6x6. For some reason the tool sprites are currently using 2 sprites though. Also there is a bug where if you save on a non-black sprite it moves down 1 row.
I also had to remove the .ppm files as they wouldn't update with the last updates you did so they went out of sync, not sure what happened there?
#16 (comment) as I said over there, the spritesheet needs to be cleaned up a bit
butctrl-xis missing right now. The cursor should also always be hidden and only show the sprite cursor when needed.Just added a
ctrl-xcut feature to rearrange/cleanup the spritesheet, check if I implemented it correctly as I'm still learning rust. And another commit to hide cursor icon, I wasn't sure where to put it so I just chose somewhere. Also re-added the new sprite you made as I started working on the spritesheet before using git pull then missed it sorry.I made a new issue that lists all of the above to quickly sum it up at #51
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.