New feature/fwd and rev reads v2 #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed an error where giving a folder directly containing reads doesnt give an Output file.
sjanssen2
approved these changes
Jul 14, 2022
| @@ -1,2 +1,8 @@ | |||
| .coverage | |||
| coverage.lcov | |||
| bowtie2.1.bt2 | |||
There was a problem hiding this comment.
you might want to be more flexible (as you don't know how many parts will be generated) by using wildcards, i.e. bowtie2.*.bt2
|
|
||
|
|
||
| def write(region, seq_chrom, annoted_ref): | ||
| region = {'V1_start': '', 'V1_end': '', |
There was a problem hiding this comment.
I don't see the reason why you "initialize" the dict with "empty" strings. Can't you check for presents of the key in downstream code?
e.g. if region['V1_start'] != '': --> if 'V1_start' in region: and once you set the value ensure that it is not empty?!
…/jlab/algorithm_vxdetector into New_Feature/fwd-and-rev-reads_v2
Stefansfixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from dictionary to pandas dataframe and fixed some minor issues