Skip to content

Commit

Permalink
Merge pull request #5 from jlagerweij/feature/issue-4
Browse files Browse the repository at this point in the history
Made member variables of ElmPluginSettings public. Only then are they…
  • Loading branch information
jlagerweij authored Apr 10, 2018
2 parents f6ad7e0 + 15daff5 commit 529bd1e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ repositories {
}

group 'org.elm.tools.external'
version '1.1.0'
version '1.2.0'
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@

@State(name = "ElmPluginSettings")
public class ElmPluginSettings implements PersistentStateComponent<ElmPluginSettings> {
private String elmMakeExecutable = "";
private String nodeExecutable = "";
private boolean pluginEnabled;
// Members need to be public for persisting preferences
@SuppressWarnings("WeakerAccess")
public String elmMakeExecutable = "";
@SuppressWarnings("WeakerAccess")
public String nodeExecutable = "";
@SuppressWarnings("WeakerAccess")
public boolean pluginEnabled;

public static ElmPluginSettings getInstance(Project project) {
return ServiceManager.getService(project, ElmPluginSettings.class);
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<idea-plugin>
<id>org.elm.tools.external</id>
<name>Elm External Tools</name>
<version>1.1.0</version>
<version>1.2.0</version>
<vendor url="http://www.github.com/jlagerweij">
Jos Lagerweij
</vendor>
Expand All @@ -19,6 +19,7 @@

<change-notes><![CDATA[
<ul>
<li><b>1.2.0</b> <em>(2018-04-10)</em> - Fix issue with saving preferences.</li>
<li><b>1.1.0</b> <em>(2018-02-20)</em> - Add node path configuration. Visible only if the elm-make is a script.</li>
<li><b>1.0.1</b> <em>(2018-02-10)</em> - Minor name change</li>
<li><b>1.0.0</b> <em>(2018-01-14)</em> - Initial release</li>
Expand Down

0 comments on commit 529bd1e

Please sign in to comment.