Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cut cell MeshData #165

Merged
merged 49 commits into from
May 1, 2024
Merged

Add new cut cell MeshData #165

merged 49 commits into from
May 1, 2024

Conversation

jlchan
Copy link
Owner

@jlchan jlchan commented Apr 29, 2024

This constructs a MeshData for cut cell meshes using subtriangulations and Caratheodory pruning to construct quadrature rules with positive weights on cut cells.

jlchan and others added 30 commits February 22, 2023 13:28
made nicer plot of Caratheodory pruning for Christina's proposal
Makes it mroe clear this file is meant for plotting
previously assumed same number of nodes on all faces
@jlchan
Copy link
Owner Author

jlchan commented Apr 30, 2024

The following is a script to plot the pruned quadrature nodes:

using Plots
using StartUpDG
using PathIntersections

N = 4
quad_rule_face = gauss_lobatto_quad(0, 0, N)
rd = RefElemData(Quad(), N; quad_rule_face)

cells_per_dimension = 2
circle = PresetGeometries.Circle(R=0.66, x0=0, y0=0)
objects = (circle, )

md = MeshData(rd, objects, cells_per_dimension)
(; cutcells) = md.mesh_type.cut_cell_data

# volume quadrature should be exact for degree N(N-1) + 2N-2 polynomials, 
# or N(N-1) + 2(N-1) = (N+2) * (N-1) degrees
N_phys_frame_geo = N^2 + N * (N-1) + 2 * (N-1) 

target_degree = 2 * N
rd_tri = RefElemData(Tri(), Polynomial(MultidimensionalQuadrature()), N, 
                    quad_rule_vol=NodesAndModes.quad_nodes_tri(N_phys_frame_geo))

plot()
for e in eachindex(cutcells)
    xq, yq, _ = StartUpDG.subtriangulated_cutcell_quadrature(cutcells[e], rd_tri)
    scatter!(vec(xq), vec(yq), label="Reference quadrature"); 
    scatter!(md.xq.cut[:, e], md.yq.cut[:, e], markersize=8, marker=:circle, 
             z_order=:back, label="Caratheodory pruning", leg=false)
end
display(plot!(leg=false))

@jlchan jlchan mentioned this pull request May 1, 2024
@jlchan jlchan merged commit add80d4 into dev May 1, 2024
8 checks passed
jlchan added a commit that referenced this pull request May 22, 2024
* Make triangle and tet node orderings consistent (#153)

* simplifying test

* fixing vertex orderings

* splitting wedge-pyr MeshData tests out

* fix triangulate tests

* fix wedge mesh ordering

* updating hardcoded values in VTK tests

* update tests

* bump compat for NodesAndModes to 1

* Bump Julia and RecursiveArrayTools compat, remove NamedArrayPartition  (#159)

* remove NamedArrayPartition files

d

* bump compat

* add sparsearrays compat entry

tests seem to be failing on CI without it?

* bump Julia compat

* bump julia CI version

* set lower compat bound for SummationByPartsOperators

* bump doc Julia version

* reexporting NamedArrayPartition

* Refactor `RefElemData` (#157)

* add comments

* comments and slight refactor

* comments and renaming Gauss -> TensorProductGaussCollocation

* update docstrings

* fix comment grammar

* remove unnecessary specialization

* removing outdated comments

* minor reorganization

* removing unnecessary functions

* reorganizing helper functions

* minor comment cleanup

* comments for Kubatko SBP

* comments

* introduce MultidimensionalQuadrature dispatch type

* fix hybrid mesh RefElemData

* fix tests

* simplify SBP RefElemData

* update invalidations

* improve comments

* more descriptive error message

for RefElemData constructors combining Tri/Tet/Wedge/Pyr with TensorProductQuadrature. This should be easy to implement in the future (Stroud)

* Add new cut cell `MeshData`  (#165)

* add some temporary test files

* fix docstrings

* remove cruft

* update plot

made nicer plot of Caratheodory pruning for Christina's proposal

* update file name

Makes it mroe clear this file is meant for plotting

* fixing cut cell demo for v1.0+

* adding Caratheodory pruning

* cleaning up cutcell demo

* improve efficiency slightly

* refactoring functions

* improve comments

* more refactoring

* generalize map_to_interval

* add new version of "generate_sampling_points"

* add dispatch to preserve old version of MeshData

* remove cruft

* add new routines to create a cut cell MeshData with positive weights

* refactoring

* fix construction of cut cell face node indices

previously assumed same number of nodes on all faces

* fix precomputation of operators

* clean up test of SBP property

* add test of SBP property using new MeshData

* add MomentFitting dispatch for old cut cell MeshData

d

* remove outdated todo

* changing wJf to wf internally

* add face node index array

* make face centroid computation more compact

* specialize connect_mesh

* add new MeshData based on subtriangulations

* add Subtriangulation() as a quadrature type

d

* add quadrature type to CutCellMesh meshtype

* test both Subtriangulation and MomentFitting

* add some docs

* allow specifying the target cut cell quadrature degree via keyword arg

* committing scratch testing files before deleting

d

* removing some scratch test files

* add tests for the weak SBP property

* fix an error when num_cartesian_cells = 0

* remove scratchpad files

* Adding hybridized SBP operators (#166)

* move old MomentFitting cut cell code into separate file

* fix default target_degree for volume quadrature

* formatting and modifying default parameters for cut interpolation nodes

* setting default boundary quadrature + renaming variables for clarity

* code cleanup

* storing cut_face_node_indices_by_elem_per_face

* adding hybridized SBP operators on cut cells

* adding cut cell hybridized SBP tests

* update test tolerances

* update hybridized SBP test tolerance

* Improve efficiency of cut-cell `MeshData` (#167)

* diagm -> Diagonal

* use views

* preallocate sorting permutation vector p

* improve efficiency of caratheodory

* remove type instability for PhysicalFrame basis

* bump compat for PathIntersections - should be more type stable

* fix compat for PathIntersections

* add docstring

* release <= 3.4 compat bound on RecursiveArrayTools

* add some NEWS.md updates

* remove SimpleUnpack and usages of @unpack

* Remove Requires.jl (#169)

* remove Requires statements in SummationByPartsOperators.jl ext

* remove requires statements in StartUpDG.jl

* add Plots extension

* remove unnecessary [extras] section (since we have test/Project.toml)

* remove unnecessary compat restriction on SummationByPartsOperators.jl

* add TriangulatePlotExt

* remove Requires.jl

* add to NEWS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant