Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Day to day life improvements + use lister for webhook handler #4

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Day to day life improvements + use lister for webhook handler #4

merged 2 commits into from
Aug 9, 2022

Conversation

jlevesy
Copy link
Owner

@jlevesy jlevesy commented Aug 9, 2022

What does this PR do?

  • Change the webhook handler so it uses a lister (k8s client cache) instead of hitting the k8s API
  • Add a couple of useful targets for the makefile, and also allow to use a test user without any permissions on the dev env

How to test this P?

make run_dev
make use_test_user_dev

k get pods (you should get kicked)

@jlevesy
feat: add helpers to generate a test user with no permissions
f865e9b
@jlevesy
chore: use listers on the webhook
19c01c0 
This involves a bit of rework of the initializations sequence as we need
to instanciate all the lister before starting up the informers.
@jlevesy jlevesy changed the title Day to day life improvent + use lister for webhook handler Day to day life improvements + use lister for webhook handler Aug 9, 2022
@jlevesy jlevesy merged commit e6ee76a into main Aug 9, 2022
@jlevesy jlevesy deleted the jl/provision-escalation branch August 9, 2022 07:38
@jlevesy jlevesy mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jlevesy