Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement escalation handler #6

Merged
merged 10 commits into from
Aug 9, 2022
Merged

Conversation

jlevesy
Copy link
Owner

@jlevesy jlevesy commented Aug 9, 2022

What does this PR do?

This PR

  • Does some refactoring again (examples, have a common escalation package instead of split webhook and event handlers packages)
  • Fixes the controller init sequence which was broken in Day to day life improvements + use lister for webhook handler #4
  • an event handler now accepts context.
  • Adds a "cutallthepossiblecorners" implementation of the escalation event handler, as well as CRDs / RBAC fixes related to this. This should be redone, but we have a clearer idea of the challenges behind this controller :)

@jlevesy jlevesy force-pushed the jl/implement-escalation-handler branch from cd3e473 to 2b06ca6 Compare August 9, 2022 16:13
@jlevesy jlevesy force-pushed the jl/implement-escalation-handler branch from 2b06ca6 to 5d929d9 Compare August 9, 2022 16:19
@jlevesy jlevesy merged commit e12ea7c into main Aug 9, 2022
@jlevesy jlevesy deleted the jl/implement-escalation-handler branch August 9, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant