-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a stage register module #92
Conversation
Hey @powerjg, when you have time could you look at this PR? I'll need it merged for the non combinational CPU. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took me so long. I scheduled time for it a few different times but things kept coming up. I have a few minor requests below. Generally, I really like the interface, and I'm impressed with your scala magic!
@@ -0,0 +1,64 @@ | |||
// Definition for a pipeline stage register module and its interface | |||
|
|||
// TODO: Change this to 'pipelined' package in a future patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! please open an issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all of the comments were addressed, though I didn't look closely. Thanks!
There's one more thing I need to do, which is to remove the |
This PR creates a
StageReg
module as specified in #91, and also changes both pipelined CPU models to utilize it.One thing I wish to improve about the interface, though I do not know how, is to allow users to access the module's inner register in the same way as regular registers, like so:
The current interface exposes the register through
io.in
andio.data
, which obscures what the module is supposed to replace and wastes keystrokes.