Allow specifying multiple line length guides. #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-heiss
force-pushed
the
multiple-line-length-guides
branch
from
75dc963
to
6f8919a
Compare
|
This PR was automatically closed when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Another small PR. This time implementing support for multiple line rulers.
It's a small convenience feature without changing any current behaviour.
I've also been running this as part of my amp build for several months now.
[ One thought: Would it be worth to change
line_length_guides()so to return aSmallVecwith e.g. 4/6/8 elements instead of a full-blownVec? ]