Allow specifying multiple values for line_length_guide in config
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @christoph-heiss! Thanks for submitting this PR. 🍻 The code changes here look great, but can I bother you to update the associated documentation as part of this change, too? |
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
christoph-heiss
force-pushed
the
multiple-line-length-guides
branch
from
225423c
to
fcec932
Compare
jmacdonald
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
LGTM! I introduced clippy checks after doing a repo-wide sweep, but lints change over time and ideally those would only be run against the changes in the PR; I'll need to get that sorted. Thanks for making an effort to address those, even if they were adjacent to this work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
long time no see :^)
Anyway, had this branch still laying around from #210, so I thought I'd quickly rebase it before it completely rots away.
Preferences now returns a
Vecinstead of anOption. As for the configuration itself, it still allows a single value as before, but also an array now. The only change from the previous PR is a change required by the new justify code, but that's pretty trivial.