Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table border size #64

Closed
jmjuanes opened this issue Jan 29, 2019 · 0 comments
Closed

Fix table border size #64

jmjuanes opened this issue Jan 29, 2019 · 0 comments
Assignees
@jmjuanes
Labels
bug Okay, Houston...we've had a problem here
Milestone
v3.3.1

Comments

@jmjuanes
Copy link
Owner

jmjuanes commented Jan 29, 2019 •
edited
Loading

Cells of the siimple-table component have different border widths when using siimple-table--border modifier.

Without siimple-table--border:
image

With siimple-table--border:
image

Solved:

image

Related issues:

  • Fixed cells border-width when the siimple-table--border modifier is not used: 1dd362d
  • Fixed cells border-width when the siimple-table--border modifier is used: 41fb887
@jmjuanes jmjuanes added the bug Okay, Houston...we've had a problem here label Jan 29, 2019
@jmjuanes jmjuanes added this to the v3.3.1 milestone Jan 29, 2019
@jmjuanes jmjuanes self-assigned this Jan 29, 2019
jmjuanes added a commit that referenced this issue Jan 29, 2019
@jmjuanes
Changed total width of rows separator border to 2px requested on #64
1dd362d
jmjuanes added a commit that referenced this issue Jan 29, 2019
@jmjuanes
Fixed cells border width when the border modifier is used requested on …
41fb887 
…#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmjuanes jmjuanes

Labels
bug Okay, Houston...we've had a problem here
Projects
None yet
Milestone
v3.3.1
Development

No branches or pull requests
1 participant
@jmjuanes