Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make users fields editable from admin UI #18

Closed
javuto opened this issue Oct 1, 2019 · 9 comments
Closed

Make users fields editable from admin UI #18

javuto opened this issue Oct 1, 2019 · 9 comments
Assignees
Labels
✨ enhancement New feature or request 🥇 good first issue Good for newcomers
Milestone

Comments

@javuto
Copy link
Collaborator

javuto commented Oct 1, 2019

Overview

When visiting Manage Users in the admin UI, some fields are not editable, such as email or full name. It would be nice to allow the edition of those fields, same as the settings are edited.

@javuto javuto added ✨ enhancement New feature or request 🥇 good first issue Good for newcomers 🎃 hacktoberfest https://hacktoberfest.digitalocean.com/details labels Oct 1, 2019
@javuto javuto added this to the v0.1.9 milestone Oct 1, 2019
@sahilsharma011
Copy link

I would like to work on this issue. I've identified that in cmd/admin/templates/users.html, email and full name fields will be made editable text inputs
And in usersPOSTHandler function, I would've to add support for updating email and full name fields along with admin flag which is being edited currently

@sahilsharma011
Copy link

@javuto I'm unable to run make docker_all command
I'm receiving an error:

req: Can't open "docker/certs/osctrl.key" for writing, No such file or directory
make: *** [Makefile:104: docker_all] Error 1

Please help

@javuto
Copy link
Collaborator Author

javuto commented Oct 1, 2019

What OS are you using? can you paste the whole output of the command?

@sahilsharma011
Copy link

sahilsharma011 commented Oct 2, 2019

I'm using Ubuntu 19.04
Here is my screen recording with output for the command

asciicast

@javuto
Copy link
Collaborator Author

javuto commented Oct 2, 2019

Just landed a fix for this issue. Most likely it was related with the directories certs and config not being created. Let me know if that fixed the problem. Thanks!

@sahilsharma011
Copy link

sahilsharma011 commented Oct 3, 2019

Yes that problem is fixed now. I am facing problem while logging in http://localhost:9001/login.
What are the credentials for this page @javuto ?

I'm not able to login with username: admin & password: admin
login API is returning status OK but it is still redirecting me back to /login url

@lashomb
Copy link

lashomb commented Oct 8, 2019

Seeing the same as @sahilsharma011

@javuto
Copy link
Collaborator Author

javuto commented Oct 10, 2019

Just to be clear, this happens after running make docker_all, correct? I am testing that from OSX and it works fine. After is ready, going to https://localhost:8443 and using admin/admin is working as expected.

@lashomb
Copy link

lashomb commented Oct 10, 2019

Oh I was trying on port 9001, will have to look at 8443.

@javuto javuto modified the milestones: v0.1.9, v0.2.0 Oct 17, 2019
@javuto javuto modified the milestones: v0.2.0, v0.2.1 Feb 26, 2020
@javuto javuto removed the 🎃 hacktoberfest https://hacktoberfest.digitalocean.com/details label Mar 8, 2020
@javuto javuto assigned javuto and unassigned sahilsharma011 Mar 8, 2020
@javuto javuto closed this as completed Mar 8, 2020
CptOfEvilMinions added a commit that referenced this issue Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request 🥇 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants