-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Plans for a better UI? (Redesign Discussion) #220
Comments
I would like to add some more colour to the UI, but I can't think of any specific bit that needs improving. Do you have any ideas? I'm not a UI person so I've been sticking to the Material guidelines 🙃 |
What issue creator might mean is that the UI is not same as in some other app they are used to. I just found Finamp, and think that the UX might be slightly better for me, than some other apps. (Myself I'm most confortable with terminal and keyboard based programs, but i'm not comparing Finamp to my tools there of course). But perhaps issue creator only means the appearance of the UI? Not at all the functionality? |
I've came across the app just now and want to try it for the offline playback capability. I've used Gelli so far (a fork of Phonograph) and while finamp's UI is not terrible, I think Gelli/Phonograph – while still quite minimal – are a wee bit neater. Some colors go a long way to make it more readable and the "now playing" screen is considerably more slick – it infers a matching background colour from the album art (the audio notification also follows that colour, which is neat) and has a really nice quick playlist access, you can even swipe it up to easily navigate to past items. It also has an alternative layout for the landscape mode that works well (I think finamp doesn't). The navigation is also more fluid – for example when you're in the track list mode and you have that bar at bottom showing the current track, then swiping it up has a continuous fluid motion of it transforming into a full screen view (while finamp has a basic fade instead), making it a subjectively more smooth experience. I'm not sure how much exactly should you ape Gelli/Phonograph, but I'd give them a spin and try navigating around (Gelli should be easier one to try, since it's also a Jellyfin client) and see how a very similar basic layout of the application feels much more polished due to just a few small differences and consistent attention to UX details. I feel like you don't have to reinvent the UI totally (it's already quite similar to Gelli/Phonograph, which I think works well), just invest a bit into polish. Also, the UI seems to lag quite a bit (and even sometimes crashes) when you're batch downloading stuff, I'd look into it (I queued some whole artists for ~5k downloads). Hopefully it's an useful 2 cents. |
Those are some really useful suggestions, thanks :) About the animation when opening the player screen - I did try to implement a nice slide animation but it's quite a hard thing to implement. I want it to sort of be like an animation as well as a page transition, which means that I have to mess about with custom navigator stuff that I don't quite understand. It's possible, and when I was looking into it I tried understanding Sweyer's implementation (and even made an issue asking how it worked lol), but ended up not looking into it futher. Another thing I'd like to add is an animation when opening the search bar, even a basic fade would help a lot. I need to refactor the main music screen because it's a mess so maybe I'll implement that if I ever get around to it. As for the UI lagging when many items are downloading, this is a known issue and should be fixed when I implement a new downloader package (#213). |
I'd like to see smoother more fluid animations. |
Hi there! I've recently started to work on a visual overhaul of the Now Playing view, and have been in touch with @jmshrv about this. Here's what I came up with so far: It should look a lot more colorful and friendly, have a clear and easy-to-reach layout and contain all the info and functionality you need. While I've tried to incorporate requests from this issues as well as others (#211 @MarkWieczorek, #208 @nathancoooper), I've also tried to make it look somewhat unique. |
This is absolutely gorgeous, personally not a fan of the boxing around the buttons I feel it makes it look constricted whereas everything else has a nice floaty look. And I would probably prefer the buttons above the seekbar. Just personal preference though. But overall beautiful! Amazing work, can't wait to see in release. |
I think that these look good. The only thing that is missing for me is the year that the album was released. would it be possible to add this after the album name? |
I've begun implementing this design in the Note that the code is a bit ugly, I'll tidy it up once I've got everything figured out |
Yeah I struggled a bit with this. Without the box the layout look a bit strange though. Will tinker a bit more :)
As of yet none of the text has background, and I feel like badges always imply being clickable. Maybe I could use an outline if that looks good, or just keep it like this. Thanks for the feedback! <3 |
One small adjustment that I would make is that I would have the title, album, and artist test all centred as opposed to pressed against the left side. Just personal preference though. |
I agree with centering |
Id like to pitch in my own ideas as well, with these (horribly drawn) drawings. I think by default its already fine, but the improvements include:
Another thing I envision is the menu that pops up when long pressing a song The pop up will take approximately half(or 75%) of the screen, and shows the album art and song name at the top, followed by the options(the order of which must be thought of). I hope @Chaphasilor can actualize this so we'd have a clearer idea on how it'd look like |
@MrPotatoBobx thanks for the mockups, they are great, honestly! It gives me additional input/ideas to go off of :) I can already tell you we're in agreement about the rounded album cover with text to the right. Also, I assume you intended to keep the information shown next to the album the same, given that you've used the same icons? Or is there some piece of information that you (don't) want to have there? I'm curious, what's the reason you would like to have the download button in this position and as a switch? Is it because this is how other apps (like Spotify) do it? And would you mind if the "Like" button were in the same spot, maybe on the opposite side? @jmshrv is it possible to get information about the "discs" through the jellyfin API? If yes, this would likely be another option that can be turned on in settings, but separation by disc would probably be off by default, given that I know no other (mobile) music player that shows albums like this. I'll think about the song layout some more, not sure yet how much space there will be for icons. I always like to maximize the width of shown text whenever possible. Maybe, once things like #125 are implemented, we could simply have taller list items that can fit more information without making scrolling long lists impossible. Regarding the song menu:
Here's the mockup: Keep the ideas, requests, criticism and drawings coming! 😁 |
I think one-handed usability should definitely be kept in mind but, as long as you can swipe to close the menu with just one hand holding your phone then I see no problem with it covering the entire screen. |
Would love to see two rows at the bottom of albums, and even playlists with "More from this artist" and "Similar to this artist" I would prefer it to cover the entire screen, however I wouldn't be opposed to the idea of adding an option that shrinks it "One Handed Mode". Also a reply about the badges for the audio quality. You could make them into buttons, that open up a box that displays highly detailed audio quality information. This would actually be very nice. Also this may be a stretch, but it would be so nice to have an option for something to grab album information. I love learning about the albums stories, and artists sometimes. Like Wikipedia for information, Genius has some info (also Lyrics!), Lastfm has some info. |
"More from this artist" should be absolutely possible. Jellyfin also seems to provide a "More like this" category through the API for albums, so guess this can also be shown. Any preferences about the layout, or do you maybe have examples of music apps that do this well?
That's a very good suggestion! Maybe we could even go as far as being able to change transcoding settings right from there!
Jellyfin provides that for artists only, not for albums, and even then only if the information is present on TheAudioDB. Whether or not we can integrate third-party meta-info fetchers is up to @jmshrv, not me. I'll try to add the description somewhere on the artist page once I get there, then it shouldn't be too hard to also add it to the album page if that is ever needed :) |
That menu could be implemented as a dialog, so pressing outside the menu would dismiss it.
Hmm, I'd have to leave API keys in the source code, which is a pretty big blocker. There are also concerns about interacting with non-free services. Maybe it would make sense as a Jellyfin plugin? That way everyone is in control of what services are used. These are all great suggestions btw :) |
I will soon get to work onto Jellyfin-server code to allow the user to chose a rating mechanism (likes or 5-stars for instance), I would be interested to see what it would look like on this gorgeous UI revamp :) |
Well I'm really not concerned about closing the menu, but about being able to properly reach all actions with one hand. But maybe it's better to test that with a working prototype ^^ |
@Kaaybi I'm sure we can figure something out once that lands, but honestly before there is an actual implementation where it is clear what the "requirements" are and how the mechanism works, I don't think it's useful to design this. This could implicate pretty big changes to how the app in organized, so it might be necessary to adapt a lot of things to support this. But if there's some sort of discussion about how this should end up working I'd be glad to read up on it and keep it in mind while designing the other things! |
This here thread is amazing, and really inspiring to watch. I check it daily, and the effort, suggestions, designs and discussion here are all superb. I don’t have the capacity to contribute at the moment, but if there is a way to patron some development, I’m up for it. I finally found Finamp as my solution to Jellyfin music, and this new design will be fantastic. I can’t imagine it will take less than a year to complete, and it will be well worth the wait. |
Not much is needed to vastly improve the UI.
Please don't take the advice of those suggesting to use quirky fonts or to aim to achieve a clone of another app. Keeping the app as simple and light as possible while using the modern Android menu system as much as possible is the way to go, similar to the philosophy of Simple Mobile Tools. "Music" by Zion Huang does this well as an example of a very lightweight app which uses the modern standard Android 12 components. If there's to be any major change to the UI I think your time is best spent using the latest Android material design for simplicity, lightness, speed, longevity, and visual appearance too. |
Beta builds have been submitted to Play Store & TestFlight for review 👀 |
Hello @PauFCB this is not yet possible. This was just a design from Chaphasilor and is not implemented yet. |
They are only temporary. Colors will adapt to the album cover on the album screen eventually, just like in the mockups |
Hi is there any issue/tracker for desktop support that was announced to be upcoming in the latest beta release? |
@AkechiShiro no, not really. It'll probably take one or two more releases to finish things up, and the desktop version will not receive the same level of support. |
I agree with this, I learned about the beta this morning trying to find a fix for the latest iOS release bug with the artists tab and this redesign beta fixes it and is honestly incredible compared to the current public release state. In your reply, @Chaphasilor, you only mention the colors will change, but I think the main issue (for me at least) is this top block is fixed in place and doesn’t disappear or shrink when scrolling down the track list. I’m also seeing the favorite hearts too close to the letter filters on artists & songs views. Curious if I could help at all with a background in CSS but seeing your earlier comment it seems not. |
I'll make the top section fade out again with the next update, until I can properly implement the header shrinking down to take up less space when scrolling. As for the favorite icons, they will get updated when I'll replacr the track list items with the redesigned version. Flutter's design approach is different from CSS, but easy enough to pick up, especially if you're used utility CSS like tailwind or boostrap before. If you want to dabble with this, you could always check out the contribution guide and open a draft PR to get some feedback and tips :D |
Just installed the beta and I think it's excellent, but there are a few things I'd like to mention:
Also, when playing a single track, please provide a way to turn off the "mix" because it's nowhere near good enough to not ruin the mood, and sometimes you only want to play a single track :) Device Info: |
Ok quick update, the latest update adds nice information about the currently plating track but is showing the wrong bitrate for songs downloaded at 256kbit AAC transcoded is showing as AAC but at the FLAC bitrate on Now Playing. The bitrate is correct in downloads, but not on now playing :) |
Yep that's a known bug, will be fixed with the next update! |
Great! Thanks!
…
On May 10, 2024 at 6:25, <Chaphasilor ***@***.***)> wrote:
Yep that's a known bug, will be fixed with the next update!
—
Reply to this email directly, view it on GitHub (#220 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ASSIEYCVQD7Q7J7BZ7QJUBLZBT7GZAVCNFSM5TUTXKKKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJQGQ4TSMZQGM4Q).
You are receiving this because you commented.Message ID: ***@***.***>
|
Really liking the beta! Regarding re-ordering the song queue. It's not possible to move the playing song or move other songs across the playing track. I tend to do this when I start a playlist from a particular song and want to re-order the queue. |
Is it possible to hide Codec, Bitrate, file size etc? while this info will required by many. But it should be optional so player ui looks minimal. Thank you |
I believe that was on The List™️ |
I've also missed that functionality myself, but at least the "moving tracks across the currently playing track" or even just between different queue sections (regular queue, Next Up, etc.) was too hard to implement for me when I tried it. There was a library that allowed it and worked almost perfectly, but it had severe performance issues with queues longer than 50 tracks, so it really wasn't an option. Theoretically, someone with enough expertise could implement this at some point, but I've spent weeks trying to get this to work back when I originally implemented it, and I'm not keen on doing that again. |
One bug I've run into once or twice is with a connected vehicle - it's a mazda, and whenever I play Lena Raine (i.e. pigstep, otherside, celeste OST etc) it shows up on the phone just fine, but on the cars display it shows "Lana Lane". Not sure if it's an issue with finamp giving incorrect metadata or if it's a bug with the car itself (I'm not sure if it's android auto or not), but I can provide more info if needed |
@TheRealGramdalf Maybe check if any part of the metadata on your files contains "Lana Lane"? I usually use kid3 to edit metadata for albums or tracks. |
I took a look (via jellyfins' web UI), and it doesn't seem to have anything. I do recall seeing something about a music database in the cars settings, but I haven't looked into it as of yet. It could be completely unrelated to finamp. |
Hello! I don't know if anyone talked about this here (I haven't found any issues dedicated for this either) But since you are packaging Finamp as a Desktop app now, it needs to have a slider for volume, somewhere. Did you ever think about this ? if yes what are your opinion on this ? Thank you for your amazing work :) |
Right now the UI is totally usable, but it looks certainly dated compared to other media streaming apps. Do you have any plans for a revamped UI?
The text was updated successfully, but these errors were encountered: