Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redesign] Within lyrics; remove the timestamp next to the line if it's empty. #737

Closed
MustThinkOfAName opened this issue May 21, 2024 · 1 comment
Closed

[Redesign] Within lyrics; remove the timestamp next to the line if it's empty. #737

MustThinkOfAName opened this issue May 21, 2024 · 1 comment
Labels
easy fix enhancement Improves an existing feature redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@MustThinkOfAName
Copy link

In .lrc files, empty timestamped lines are often used to demarcate verses. In my opinion, timestamping should not apply there.

signal-2024-05-21-205856_002
@Chaphasilor
Copy link
Collaborator

That's a good point. I'll do that for the 0.9.8 release!

@Chaphasilor Chaphasilor added enhancement Improves an existing feature easy fix redesign-beta Issues related to the beta/redsigned version of Finamp labels May 23, 2024
Chaphasilor added a commit that referenced this issue May 31, 2024
@Chaphasilor
add setting for hiding lyrics timestamps to new lyrics settings screen
09e2b79 
- also hide timestamps for empty lines, fixes #737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy fix enhancement Improves an existing feature redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Finamp Redesign
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chaphasilor @MustThinkOfAName