Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added doc remark for returning pixel_coordinates #95

Merged
merged 2 commits into from Oct 22, 2020
Merged

Conversation

theo258
Copy link
Contributor

@theo258 theo258 commented Sep 1, 2020

Added a remark that the first entry in the returning pixel_coordinates is always zero to match the index of the pixels (c.f. #93)
(My first pull request so correct me if something went wrong.)

Added a remark that the first entry in the returning pixel_coordinates is always zero to match the index of the pixels (c.f. jni#93).
added doc remark for returning pixel_coordinates
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.453% when pulling 96dd851 on theo258:master into 81fff8b on jni:master.

@theo258
Copy link
Contributor Author

theo258 commented Sep 1, 2020

Is there a reason why the pixel_coordinates array is returned as float? As these values can only be integers one could save them as int by changing pixel_indices = np.concatenate(([[0.] * ndim],... to pixel_indices = np.concatenate(([[0] * ndim],... in csr.py. I'll create another pull request if that sounds useful.

@jni jni merged commit ef6df1f into jni:master Oct 22, 2020
@jni
Copy link
Owner

jni commented Oct 22, 2020

Gah, I'm sorry I missed this for so long, @theo258! Thank you very much for this tweak!

Is there a reason why the pixel_coordinates array is returned as float?

Yes, unique_junctions= replaces junctions containing more than one pixel with their centroid, which can be float. This is described in detail in the paper supplementary info, but should probably go in the docs. I'm still not sure about best approaches here, and suggestions are very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants