Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete dialogue #20

Closed
clumsyfingers opened this issue Mar 20, 2020 · 5 comments
Closed

delete dialogue #20

clumsyfingers opened this issue Mar 20, 2020 · 5 comments

Comments

@clumsyfingers
Copy link

clumsyfingers commented Mar 20, 2020

firstly thanks for keeping arc alive!
secondly, this has been bothering me for ages https://i.imgur.com/0CU4TWB.png
themes without that top bar look so much better. can something be done?

thirdly, im dreaming about a compact version. but a lot of work i guess

@jnsh
Copy link
Owner

jnsh commented Mar 20, 2020

Thank you for the report.

What WM/Desktop and application is the delete dialog from?
Also, how does the dialog look with default theme, and/or how exactly you'd prefer it to look?

There are no plans for variants with major differences in styling, as there's no easy way of making this configurable for every supported desktop and toolkit. I think such variants should be developed as separate forks.

@clumsyfingers
Copy link
Author

clumsyfingers commented Mar 21, 2020

hi, its on gnome but is the same also on budgie. its just the standard delete dialogue in nautilus
here its shown with plata, qogir and arc darker https://imgur.com/a/1X4Jdcd
its just that top bar in arc thats ugly imho

@jnsh
Copy link
Owner

jnsh commented Mar 21, 2020

I see. Apparently the bar isn't visible on Adwaita either, so it makes sense to follow upstream on this.

I'll fix this at some point, but it's not the highest priority at the moment.
Pull requests are welcome, if anyone wants to help with this.

@jnsh
Copy link
Owner

jnsh commented Jul 28, 2020

Bit of a status update.

I investigated this awhile ago and it seemed that the modal dialog titlebar styling was intentional design choice from the original designer, and already present in the first version of the theme IIRC. Therefore I wouldn't like to remove it. Additionally it seemed that changing this would require quite big reorganizing of the theme stylesheet.

IMHO the biggest visual issue with the current design is that there's no padding between the titlebar and the modal dialog message, which makes it look unbalanced. I was thinking about merely adding some padding there, rather than removing the titlebar altogether.

Let me know if you have any feedback on this, or any other suggestions.

@jnsh
Copy link
Owner

jnsh commented Feb 17, 2022

I've added some padding between the dialog titlebar and content in a394a76, which IMHO looks much nicer:

Screenshot from 2022-02-17 15-58-01

If anyone still wants to get rid of the dialog titlebar, it can be done with simple CSS injection, e.g.:
For GTK3, ~/.config/gtk-3.0/gtk.css:

messagedialog .titlebar {
  background-color: @theme_bg_color;
  border-bottom: none;
  box-shadow: none;
}

messagedialog box.dialog-vbox.vertical {
  padding-top: 0;
}

For GTK4, ~/.config/gtk-4.0/gtk.css:

window.dialog.message .titlebar {
  background-color: @theme_bg_color;
  border-bottom: none;
  box-shadow: none;
}

window.dialog.message box.dialog-vbox.vertical {
  padding-top: 0;
}

Closing.

@jnsh jnsh closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants