Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for easy instrumentation #4

Closed
jnunemaker opened this issue Nov 6, 2012 · 5 comments
Closed

Allow for easy instrumentation #4

jnunemaker opened this issue Nov 6, 2012 · 5 comments

Comments

@jnunemaker
Copy link
Owner

No description provided.

@technoweenie
Copy link

I don't know what you're planning, but ActiveSupport::Notifications is pretty good. I have a good backport that we use on .com so you don't necessarily need all of AS. https://github.com/technoweenie/activesupport_notifications_backport

@jnunemaker
Copy link
Owner Author

Yeah I just added instrumentation to flipper and ill probably do it the same way. It just requires the interface to be right and not necessarily AS.

On Jan 19, 2013, at 4:28 PM, rick notifications@github.com wrote:

I don't know what you're planning, but ActiveSupport::Notifications is pretty good. I have a good backport that we use on .com so you don't necessarily need all of AS. https://github.com/technoweenie/activesupport_notifications_backport


Reply to this email directly or view it on GitHub.

@technoweenie
Copy link

Oh right on. I've been doing the same in Faraday.

On Sat, Jan 19, 2013 at 3:54 PM, John Nunemaker notifications@github.comwrote:

Yeah I just added instrumentation to flipper and ill probably do it the
same way. It just requires the interface to be right and not necessarily
AS.

On Jan 19, 2013, at 4:28 PM, rick notifications@github.com wrote:

I don't know what you're planning, but ActiveSupport::Notifications is
pretty good. I have a good backport that we use on .com so you don't
necessarily need all of AS.
https://github.com/technoweenie/activesupport_notifications_backport


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-12463446.

Rick Olson
http://github.com/technoweenie

@jnunemaker
Copy link
Owner Author

Sweet. I'll play around with this in the coming week. It was really easy to add to flipper.

flippercloud/flipper#15

@jnunemaker
Copy link
Owner Author

Closed thanks to #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants