Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to MultiJson's new load API #134

Merged
merged 1 commit into from
Apr 21, 2012
Merged

Updating to MultiJson's new load API #134

merged 1 commit into from
Apr 21, 2012

Conversation

zmoazeni
Copy link

MultiJson is deprecating the decode/encode methods in favor of load/dump as of https://github.com/intridea/multi_json/tree/e90fd6cb1b0293eb0c73c2f4eb0f7a1764370216 which was pushed out in v1.3.0.

This pull request updates the API to call MultiJson.load to get rid of the deprecated messages and updates the gemspec to depend on >= 1.3.0 so nothing weird happens with mismatched versions.

@zmoazeni
Copy link
Author

The >= 1.3.0 may be too lax considering Rails v3.2 is locking down to ~> 1.3 in rails/rails@625f4b9#activesupport/activesupport.gemspec

Edit

Bleh, I was looking at the wrong commit. v3.2 does have it locked down to < 1.3 in https://github.com/rails/rails/blob/3-2-stable/activesupport/activesupport.gemspec

@javierg
Copy link

javierg commented Apr 18, 2012

+1

@zmoazeni
Copy link
Author

I'm keeping an eye on rails/rails#5896 - if that gets merged in, we will be alright sticking with >= 1.3

@zmoazeni
Copy link
Author

Looks like rails merged in a fix that allows >= 1.3 rails/rails#5896 (comment)

v1.3.0 is where load/unload were added to MultiJson

Edit: Actually it's ~> 1.0, perhaps tweaking it to ~> 1.3 would be better than >= 1.3 in this context

@jnunemaker jnunemaker merged commit 82908f3 into jnunemaker:master Apr 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants